Fix RocketChat/Rocket.Chat#329. Check for duplicate name before creating Channel and Private Group. Also, check Private Group for illegal name. #330
Conversation
channel or private group Queried ChatRoom for Room with same name and returned a descriptive error if one was found when creating a Channel or Private Group.
|
Hi @sampaiodiego, sorry, I forgot about internationalizing it. =) I'll add it to the en.il8n.json, but what about the other languages? Do I add it in English so it's not forgotten? |
|
Exactly. Do it only for english, other languages will be translated later Em qui, 23 de jul de 2015 16:26, Reid Wakida notifications@github.com
|
private group and channel. Check for illegal name for private group. - Use il8n for error messages - Add il8n english error message for duplicate channel/private group name - Add illegal name serverside check to createPrivateGroup method - Add logic to handle different error types on privateGroupsFlex page
|
HI @sampaiodiego. I updated the code to use il8n. Also, I realized that private groups didn't check for illegal names like channel does so I added the validation to createPrivateGroup.coffee. |
rwakida
changed the title
|
well done @rwakida .. thank you again =) |
Fix multiple certificate notifications and replacing webview with image
2 participants
channel or private group
Queried ChatRoom for Room with same name and returned a descriptive
error if one was found when creating a Channel or Private Group.