Skip to content

Comments

feat: VoIP freeswitch UI internals#33005

Merged
pierre-lehnen-rc merged 10 commits intofeat/freeswitch-6-12from
feat/voip-freeswitch-ui-internals
Sep 24, 2024
Merged

feat: VoIP freeswitch UI internals#33005
pierre-lehnen-rc merged 10 commits intofeat/freeswitch-6-12from
feat/voip-freeswitch-ui-internals

Conversation

@aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Aug 7, 2024

❗❗DO NOT MERGE BEFORE #33004❗❗

Proposed changes (including videos or screenshots)

This PR adds the foundations for the new VoIP for team collab feature.

The changes can be broken down into:

VoipClient

This class is responsible for all SIP communications using the sip.js library. It is the heart of the VoIP functionality, it communicates with the FreeSWITCH backend and serves as an event emitter and ssot for the interface.

useVoipClient

React hook responsible for instantiating VoipClient and calling for the initial register. This ensures only one instance of VoIPClient exists at a time.

VoipProvider

React provider mainly responsible for providing access to VoipClient to the rest of application. It also orchestrates actions like changing device input/output and listening for call events and triggering sounds.

Issue(s)

VOIP-45
VOIP-47
VOIP-48

Steps to test or reproduce

N/A

Further comments

ℹ️ Commits can be used to navigate better each of the mentioned components.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Aug 7, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Aug 7, 2024

⚠️ No Changeset found

Latest commit: 7c0ba3c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-internals branch 4 times, most recently from f66c278 to 21c8cc0 Compare August 14, 2024 18:57
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-internals branch from 21c8cc0 to 0eab322 Compare August 16, 2024 18:13
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-admin branch from 230140f to 7075979 Compare August 20, 2024 15:42
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-internals branch from 0eab322 to 468327f Compare August 20, 2024 16:08
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-admin branch from 7075979 to 8129cb2 Compare August 20, 2024 16:46
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-internals branch from 468327f to fb38fe1 Compare August 20, 2024 17:29
@codecov
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feat/freeswitch-6-12@8389ec1). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##             feat/freeswitch-6-12   #33005   +/-   ##
=======================================================
  Coverage                        ?   59.69%           
=======================================================
  Files                           ?     2553           
  Lines                           ?    62812           
  Branches                        ?    14107           
=======================================================
  Hits                            ?    37495           
  Misses                          ?    22910           
  Partials                        ?     2407           
Flag Coverage Δ
unit 76.85% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva marked this pull request as ready for review August 20, 2024 20:39
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner August 20, 2024 20:39
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Aug 20, 2024
@aleksandernsilva aleksandernsilva marked this pull request as draft August 20, 2024 20:41
@aleksandernsilva aleksandernsilva added this to the 6.12 milestone Aug 21, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 21, 2024
@aleksandernsilva aleksandernsilva removed the stat: QA assured Means it has been tested and approved by a company insider label Aug 21, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Aug 21, 2024
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-admin branch from 5f365d3 to c9a70d6 Compare August 22, 2024 00:24
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-internals branch from fb38fe1 to be70e77 Compare August 22, 2024 00:25
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-admin branch from c9a70d6 to 69208b5 Compare August 22, 2024 01:41
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-internals branch from be70e77 to 4057c92 Compare August 22, 2024 01:43
@aleksandernsilva aleksandernsilva marked this pull request as ready for review August 22, 2024 04:29
@rodrigok rodrigok modified the milestones: 6.12, 6.13 Aug 22, 2024
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-admin branch from 256cdd8 to a653119 Compare September 11, 2024 19:00
@aleksandernsilva aleksandernsilva requested review from a team as code owners September 17, 2024 00:41
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-internals branch from 020a4ef to a2562d9 Compare September 17, 2024 17:17
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-admin branch from b704c4c to f4d5a44 Compare September 18, 2024 16:44
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-internals branch from ae959c7 to 0ae01b4 Compare September 18, 2024 16:52
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-internals branch from 54b5bc3 to 9f35ee3 Compare September 23, 2024 00:15
Base automatically changed from feat/voip-freeswitch-ui-admin to feat/freeswitch-6-12 September 23, 2024 13:46
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-internals branch from 9f35ee3 to bc259eb Compare September 23, 2024 17:34
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backend

@pierre-lehnen-rc pierre-lehnen-rc merged commit c91b790 into feat/freeswitch-6-12 Sep 24, 2024
@pierre-lehnen-rc pierre-lehnen-rc deleted the feat/voip-freeswitch-ui-internals branch September 24, 2024 14:15
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Sep 24, 2024
@aleksandernsilva aleksandernsilva modified the milestones: 6.13, 6.14 Sep 26, 2024
@ggazzo ggazzo modified the milestones: 6.14, 7.0 Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants