Skip to content

Comments

feat: VoIP freeswitch UI hooks#33006

Merged
tassoevan merged 1 commit intofeat/voip-freeswitch-ui-internalsfrom
feat/voip-freeswitch-ui-hooks
Aug 22, 2024
Merged

feat: VoIP freeswitch UI hooks#33006
tassoevan merged 1 commit intofeat/voip-freeswitch-ui-internalsfrom
feat/voip-freeswitch-ui-hooks

Conversation

@aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Aug 7, 2024

❗❗DO NOT MERGE BEFORE #33005❗❗

Proposed changes (including videos or screenshots)

This PR adds the mais React hooks used by the UI for voice calls. Each hook has it's own responsibility and informations is extracted from the VoIPClient.

Here's a description of each hook and it's responsibilities:

useVoiceCallState

Provides information is regards to the state of the VoIPClient and VoiceCallSession. Ex.: isReady, isRegistered, isError, isIncoming, isOngoing, isOutgoing

useVoiceCallAPI

Provides access to VoIPClient actions not necessarily related to the current VoiceCallSession. Ex.: register, unregister, transferCall, makeCall, endCall.

useVoiceCallSession

Provides access to the state and actions available for the established voice call.
A VoiceCallSession can be INCOMING, ONGOING, OUTGOING and ERROR. Each session type provides a group of methods (Ex.: mute; hold) and relevant information (Ex.: contact; transferedBy).

useVoiceCall

This is a convenience hook that combines state, api and session in a single result.

useVoiceCallDialer

Provides the state of the dialer, whether it's open and a close method.

-- The following hooks are used mostly as support for the previous hooks

useVoiceCallEvent

Listens for events coming from the VoIPClient, stores and returns the payload as a result.

useVoiceCallEffect

Listens for stateChanged emitted by VoIPClient and calls a callback with the updated VoIPClient. The callback's return is the result.

Issue(s)

VOIP-48

Steps to test or reproduce

N/A

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Aug 7, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Aug 7, 2024

⚠️ No Changeset found

Latest commit: e764573

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-internals branch from 8993d60 to 4f5ed09 Compare August 8, 2024 13:48
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-hooks branch from 7a5417c to 1fce147 Compare August 8, 2024 13:51
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-internals branch from 4f5ed09 to 23b56b2 Compare August 8, 2024 15:50
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-hooks branch from 1fce147 to 03d2aa4 Compare August 8, 2024 15:51
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-internals branch from 23b56b2 to f66c278 Compare August 14, 2024 17:30
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-hooks branch from 03d2aa4 to 4ebcd51 Compare August 14, 2024 17:30
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-internals branch from f66c278 to 21c8cc0 Compare August 14, 2024 18:57
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-hooks branch 2 times, most recently from f8839ed to 43403c6 Compare August 14, 2024 19:15
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-internals branch from 21c8cc0 to 0eab322 Compare August 16, 2024 18:13
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-hooks branch from 43403c6 to a05967d Compare August 16, 2024 18:16
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-internals branch from 0eab322 to 468327f Compare August 20, 2024 16:08
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-hooks branch from a05967d to acdc357 Compare August 20, 2024 16:11
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-internals branch from 468327f to fb38fe1 Compare August 20, 2024 17:29
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-hooks branch from acdc357 to 80684ee Compare August 20, 2024 17:31
@codecov
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.39%. Comparing base (4057c92) to head (e764573).
Report is 1 commits behind head on feat/voip-freeswitch-ui-internals.

Additional details and impacted files

Impacted file tree graph

@@                        Coverage Diff                         @@
##           feat/voip-freeswitch-ui-internals   #33006   +/-   ##
==================================================================
  Coverage                              59.39%   59.39%           
==================================================================
  Files                                   2549     2549           
  Lines                                  63332    63332           
  Branches                               14253    14253           
==================================================================
  Hits                                   37617    37617           
  Misses                                 22996    22996           
  Partials                                2719     2719           
Flag Coverage Δ
unit 75.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Aug 20, 2024
@aleksandernsilva aleksandernsilva added this to the 6.12 milestone Aug 21, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 21, 2024
@aleksandernsilva aleksandernsilva removed the stat: QA assured Means it has been tested and approved by a company insider label Aug 21, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Aug 21, 2024
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-internals branch from fb38fe1 to be70e77 Compare August 22, 2024 00:25
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-hooks branch from 80684ee to cddd225 Compare August 22, 2024 00:26
@aleksandernsilva aleksandernsilva marked this pull request as ready for review August 22, 2024 01:34
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner August 22, 2024 01:34
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-internals branch from be70e77 to 4057c92 Compare August 22, 2024 01:43
@tassoevan tassoevan merged commit 91ee486 into feat/voip-freeswitch-ui-internals Aug 22, 2024
@tassoevan tassoevan deleted the feat/voip-freeswitch-ui-hooks branch August 22, 2024 04:56
@aleksandernsilva aleksandernsilva modified the milestones: 6.12, 6.13 Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants