fix: correct parameter order in afterSaveMessage to restore outgoing webhooks and related features by ricardogarim · Pull Request #33295 · RocketChat/Rocket.Chat

ricardogarim · 2024-09-16T15:40:40Z

After upgrading from Rocket.Chat version 6.9.0 to 6.12.0, outgoing integrations stopped functioning. The root cause was traced to a change in the parameter order passed by the afterSendMessage callback to the sendMessage event from the integrations app triggers. Specifically, the room parameter was not forwarded correctly, resulting in errors when searching for outgoing webhook triggers.

This issue was introduced by PR #33034, which modified the afterSaveMessage parameter signature but did not update the corresponding integration logic.

As outlined in SUP-665, this malfunction blocked the propagation of certain actions due to the callback failing to forward the correct parameters.

This PR resolves the issue by correcting the parameter order, ensuring the room parameter is passed correctly, thus restoring the functionality of outgoing webhooks.

Additionally, the same issue affected the following areas, which have now been fixed:

IRC Bridge: Fixed an issue where the service failed to bind Rocket.Chat users with their correct IRC nickname or channel path.
Autotranslate: Resolved an issue preventing messages from being automatically translated.
EngagementDashboard: Corrected the issue where new messages were not being counted in the engagement dashboard.

dionisio-bot · 2024-09-16T15:40:44Z

Looks like this PR is not ready to merge, because of the following issues:

This PR is targeting the wrong base branch. It should target 6.12.0, but it targets 6.13.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

changeset-bot · 2024-09-16T15:40:44Z

🦋 Changeset detected

Latest commit: 5c6f124

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/models	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-09-16T15:42:46Z

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-17 14:06 UTC

codecov · 2024-09-16T15:48:16Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.70%. Comparing base (b919221) to head (5c6f124).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #33295   +/-   ##
========================================
  Coverage    59.70%   59.70%           
========================================
  Files         2551     2551           
  Lines        62792    62792           
  Branches     14102    14102           
========================================
  Hits         37492    37492           
  Misses       22893    22893           
  Partials      2407     2407

Flag	Coverage Δ
unit	`76.91% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

apps/meteor/app/integrations/server/triggers.ts

apps/meteor/app/irc/server/irc-bridge/index.js

scuciatto · 2024-09-17T14:23:49Z

/patch

…webhooks and related features (#33295)

dionisio-bot · 2024-09-17T14:24:26Z

Pull request #33304 added to Project: "undefined"

…webhooks and related features (#33295)

* Bump 6.12.1 * fix: message parser being slow to process very long messages with too many symbols (#33254) Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com> * fix: Allow to use the token from `room.v` when requesting transcript instead of finding visitor (#33242) Co-authored-by: Kevin Aleman <11577696+KevLehman@users.noreply.github.com> * fix: Retention Policy cached settings not updated during upgrade procedure (#33265) Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com> * fix: imported fixes (#33268) Co-authored-by: Julio A. <52619625+julio-cfa@users.noreply.github.com> * Release 6.12.1 [no ci] * fix: Federation callback not awaiting model call (#33298) * fix: correct parameter order in afterSaveMessage to restore outgoing webhooks and related features (#33295) * feat: New endpoint for listing rooms & discussions from teams (#33177) * chore: Update typings on callbacks to accept less than a full room object (#33305) * fix: resolve avatar download issue on setUsername by refining service selection logic (#33193) * feat: Allow managing association to business units on departments' creation and update (#32682) * fix: Local avatars prioritized over external avatar provider and remove remnant references on client of `Accounts_AvatarExternalProviderUrl` (#33296) Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com> * fix: Mark as unread not working (#32939) Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com> * refactor: Remove old `setreaction` callbacks and use new after/before callbacks (#33309) * fix: `LivechatSessionTaken` webhook event called without `agent` param (#33209) * fix: error on sendmessage stub (#33317) * feat: contextualbar based on chat size (#33321) * feat: `RoomSidepanel` (#33225) Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com> * ci: auto candidate releases (#33325) Co-authored-by: Diego Sampaio <chinello@gmail.com> * refactor: Reactions set/unset (#32994) * feat: E2EE messages mentions (#32510) * fix: markdown inconsistency with bold and italics (#33157) * fix: conference calls are shown as "not answered" after they end (#33179) * Release 6.13.0-rc.0 * chore: update E2EE setting text (#33226) * feat: Implement proper accessbility for report user modal (#33294) Co-authored-by: Tasso Evangelista <2263066+tassoevan@users.noreply.github.com> * fix: imported fixes (#33330) * chore: create network broker package (#33338) * feat: Adds new admin feature preview setting management (#33212) Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> * chore: move common files to core-services (#33341) * regression: `Sidepanel` color highlight (#33342) * feat: Adds new admin feature preview setting management (#33212) Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> * fix: Avoid destructuring `connectionData` when value is undefined (#33339) * Release 6.13.0-rc.1 [no ci] * chore: replace Meteor._localStorage -> Accounts.storageLocation (#33356) * Bump rocket.chat to 6.14.0-develop (#33366) * ci: use node20 for release action (#33343) --------- Co-authored-by: rocketchat-github-ci <buildmaster@rocket.chat> Co-authored-by: dionisio-bot[bot] <117394943+dionisio-bot[bot]@users.noreply.github.com> Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com> Co-authored-by: Kevin Aleman <11577696+KevLehman@users.noreply.github.com> Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com> Co-authored-by: Julio A. <52619625+julio-cfa@users.noreply.github.com> Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> Co-authored-by: Kevin Aleman <kaleman960@gmail.com> Co-authored-by: Ricardo Garim <rswarovsky@gmail.com> Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com> Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat> Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat> Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com> Co-authored-by: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com> Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com> Co-authored-by: Diego Sampaio <chinello@gmail.com> Co-authored-by: Hugo Costa <hugocarreiracosta@gmail.com> Co-authored-by: csuadev <72958726+csuadev@users.noreply.github.com> Co-authored-by: Henrique Guimarães Ribeiro <43561537+rique223@users.noreply.github.com> Co-authored-by: Tasso Evangelista <2263066+tassoevan@users.noreply.github.com> Co-authored-by: Lucas Pelegrino <lucas.pelegrino@icloud.com> Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>

…webhooks and related features (#33295)

ricardogarim force-pushed the regression/integration-sendMessage branch from efd5b78 to d0e5554 Compare September 16, 2024 15:42

ricardogarim force-pushed the regression/integration-sendMessage branch from d0e5554 to 3fcf0fa Compare September 16, 2024 15:55

fix: correct parameter order in callbackHandler

15a7b3c

ricardogarim force-pushed the regression/integration-sendMessage branch from 3fcf0fa to 15a7b3c Compare September 16, 2024 15:57

ricardogarim added 2 commits September 16, 2024 13:24

add changeset

48d9e42

fix: correct parameter order on irc-brige

e294569

ricardogarim changed the title ~~regression: fix parameter order in callbackHandler to restore outgoing integrations~~ fix: parameter order in callbackHandler to restore outgoing integrations Sep 16, 2024

ricardogarim marked this pull request as ready for review September 16, 2024 19:03

sampaiodiego added this to the 6.12 milestone Sep 16, 2024

change changeset message

337d891

ricardogarim changed the title ~~fix: parameter order in callbackHandler to restore outgoing integrations~~ fix: correct parameter order in afterSaveMessage to restore outgoing webhooks and related features Sep 16, 2024

jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Sep 16, 2024

dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 16, 2024

ricardogarim requested review from a team and MarcosSpessatto September 16, 2024 22:46

MarcosSpessatto suggested changes Sep 17, 2024

View reviewed changes

apps/meteor/app/integrations/server/triggers.ts Show resolved Hide resolved

apps/meteor/app/irc/server/irc-bridge/index.js Outdated Show resolved Hide resolved

change irc-bridge call params

85077f3

ricardogarim force-pushed the regression/integration-sendMessage branch from b3ba9ce to 85077f3 Compare September 17, 2024 11:22

MarcosSpessatto approved these changes Sep 17, 2024

View reviewed changes

Merge branch 'develop' into regression/integration-sendMessage

5c6f124

kodiakhq bot merged commit 636d32d into develop Sep 17, 2024

kodiakhq bot deleted the regression/integration-sendMessage branch September 17, 2024 14:06

dionisio-bot bot pushed a commit that referenced this pull request Sep 17, 2024

fix: correct parameter order in afterSaveMessage to restore outgoing …

05e8e25

…webhooks and related features (#33295)

dionisio-bot bot mentioned this pull request Sep 17, 2024

fix: correct parameter order in afterSaveMessage to restore outgoing webhooks and related features #33304

Merged

scuciatto modified the milestones: 6.12, 6.13 Sep 17, 2024

rocketchat-github-ci mentioned this pull request Sep 20, 2024

Release 6.13.0 #33326

Merged

KevLehman pushed a commit that referenced this pull request Sep 20, 2024

fix: correct parameter order in afterSaveMessage to restore outgoing …

0a47b3a

…webhooks and related features (#33295)

abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024

fix: correct parameter order in afterSaveMessage to restore outgoing …

38609da

…webhooks and related features (#33295)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

fix: correct parameter order in afterSaveMessage to restore outgoing webhooks and related features#33295

fix: correct parameter order in afterSaveMessage to restore outgoing webhooks and related features#33295
kodiakhq[bot] merged 6 commits intodevelopfrom
regression/integration-sendMessage

ricardogarim commented Sep 16, 2024 •

edited by atlassian bot

Loading

Uh oh!

dionisio-bot bot commented Sep 16, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Sep 16, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Sep 16, 2024 •

edited

Loading

Uh oh!

codecov bot commented Sep 16, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

scuciatto commented Sep 17, 2024

Uh oh!

dionisio-bot bot commented Sep 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

Conversation

ricardogarim commented Sep 16, 2024 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dionisio-bot bot commented Sep 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Sep 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Sep 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

scuciatto commented Sep 17, 2024

Uh oh!

dionisio-bot bot commented Sep 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ricardogarim commented Sep 16, 2024 •

edited by atlassian bot

Loading

dionisio-bot bot commented Sep 16, 2024 •

edited

Loading

changeset-bot bot commented Sep 16, 2024 •

edited

Loading

github-actions bot commented Sep 16, 2024 •

edited

Loading

codecov bot commented Sep 16, 2024 •

edited

Loading