refactor: Remove old `setreaction` callbacks and use new after/before callbacks by KevLehman · Pull Request #33309 · RocketChat/Rocket.Chat

KevLehman · 2024-09-17T20:00:08Z

Proposed changes (including videos or screenshots)

Removes unused setReaction unsetReaction callbacks from the UI
Removes unused setReaction unsetReaction callbacks from the server
Updated the only listener of those callbacks (on the server) to use the new afterSetReaction afterUnsetReaction callbacks

Issue(s)

CORE-597
https://rocketchat.atlassian.net/browse/CORE-597

Steps to test or reproduce

Further comments

Separated from #32994

… callbacks

dionisio-bot · 2024-09-17T20:00:12Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

changeset-bot · 2024-09-17T20:00:12Z

⚠️ No Changeset found

Latest commit: aeb67bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2024-09-17T20:02:05Z

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-18 16:39 UTC

codecov · 2024-09-17T20:20:43Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.85%. Comparing base (ba8bee4) to head (aeb67bf).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #33309   +/-   ##
========================================
  Coverage    59.84%   59.85%           
========================================
  Files         2554     2554           
  Lines        63011    63008    -3     
  Branches     14129    14129           
========================================
  Hits         37711    37711           
+ Misses       22893    22890    -3     
  Partials      2407     2407

Flag	Coverage Δ
unit	`77.14% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

… callbacks (#33309)

…hAvatarById * 'develop' of github.com:RocketChat/Rocket.Chat: feat: Implement proper accessbility for report user modal (#33294) chore: update E2EE setting text (#33226) fix: conference calls are shown as "not answered" after they end (#33179) fix: markdown inconsistency with bold and italics (#33157) feat: E2EE messages mentions (#32510) refactor: Reactions set/unset (#32994) ci: auto candidate releases (#33325) feat: `RoomSidepanel` (#33225) feat: contextualbar based on chat size (#33321) fix: error on sendmessage stub (#33317) fix: `LivechatSessionTaken` webhook event called without `agent` param (#33209) refactor: Remove old `setreaction` callbacks and use new after/before callbacks (#33309) fix: Mark as unread not working (#32939) fix: Local avatars prioritized over external avatar provider and remove remnant references on client of `Accounts_AvatarExternalProviderUrl` (#33296) feat: Allow managing association to business units on departments' creation and update (#32682)

* Bump 6.12.1 * fix: message parser being slow to process very long messages with too many symbols (#33254) Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com> * fix: Allow to use the token from `room.v` when requesting transcript instead of finding visitor (#33242) Co-authored-by: Kevin Aleman <11577696+KevLehman@users.noreply.github.com> * fix: Retention Policy cached settings not updated during upgrade procedure (#33265) Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com> * fix: imported fixes (#33268) Co-authored-by: Julio A. <52619625+julio-cfa@users.noreply.github.com> * Release 6.12.1 [no ci] * fix: Federation callback not awaiting model call (#33298) * fix: correct parameter order in afterSaveMessage to restore outgoing webhooks and related features (#33295) * feat: New endpoint for listing rooms & discussions from teams (#33177) * chore: Update typings on callbacks to accept less than a full room object (#33305) * fix: resolve avatar download issue on setUsername by refining service selection logic (#33193) * feat: Allow managing association to business units on departments' creation and update (#32682) * fix: Local avatars prioritized over external avatar provider and remove remnant references on client of `Accounts_AvatarExternalProviderUrl` (#33296) Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com> * fix: Mark as unread not working (#32939) Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com> * refactor: Remove old `setreaction` callbacks and use new after/before callbacks (#33309) * fix: `LivechatSessionTaken` webhook event called without `agent` param (#33209) * fix: error on sendmessage stub (#33317) * feat: contextualbar based on chat size (#33321) * feat: `RoomSidepanel` (#33225) Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com> * ci: auto candidate releases (#33325) Co-authored-by: Diego Sampaio <chinello@gmail.com> * refactor: Reactions set/unset (#32994) * feat: E2EE messages mentions (#32510) * fix: markdown inconsistency with bold and italics (#33157) * fix: conference calls are shown as "not answered" after they end (#33179) * Release 6.13.0-rc.0 * chore: update E2EE setting text (#33226) * feat: Implement proper accessbility for report user modal (#33294) Co-authored-by: Tasso Evangelista <2263066+tassoevan@users.noreply.github.com> * fix: imported fixes (#33330) * chore: create network broker package (#33338) * feat: Adds new admin feature preview setting management (#33212) Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> * chore: move common files to core-services (#33341) * regression: `Sidepanel` color highlight (#33342) * feat: Adds new admin feature preview setting management (#33212) Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> * fix: Avoid destructuring `connectionData` when value is undefined (#33339) * Release 6.13.0-rc.1 [no ci] * chore: replace Meteor._localStorage -> Accounts.storageLocation (#33356) * Bump rocket.chat to 6.14.0-develop (#33366) * ci: use node20 for release action (#33343) --------- Co-authored-by: rocketchat-github-ci <buildmaster@rocket.chat> Co-authored-by: dionisio-bot[bot] <117394943+dionisio-bot[bot]@users.noreply.github.com> Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com> Co-authored-by: Kevin Aleman <11577696+KevLehman@users.noreply.github.com> Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com> Co-authored-by: Julio A. <52619625+julio-cfa@users.noreply.github.com> Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> Co-authored-by: Kevin Aleman <kaleman960@gmail.com> Co-authored-by: Ricardo Garim <rswarovsky@gmail.com> Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com> Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat> Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat> Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com> Co-authored-by: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com> Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com> Co-authored-by: Diego Sampaio <chinello@gmail.com> Co-authored-by: Hugo Costa <hugocarreiracosta@gmail.com> Co-authored-by: csuadev <72958726+csuadev@users.noreply.github.com> Co-authored-by: Henrique Guimarães Ribeiro <43561537+rique223@users.noreply.github.com> Co-authored-by: Tasso Evangelista <2263066+tassoevan@users.noreply.github.com> Co-authored-by: Lucas Pelegrino <lucas.pelegrino@icloud.com> Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>

… callbacks (#33309)

remove old setreaction callbacks and use new after/before setreaction…

3953c4a

… callbacks

KevLehman marked this pull request as ready for review September 18, 2024 14:39

KevLehman requested a review from MarcosSpessatto September 18, 2024 14:39

MarcosSpessatto approved these changes Sep 18, 2024

View reviewed changes

KevLehman added stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge labels Sep 18, 2024

dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Sep 18, 2024

KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Sep 18, 2024

KevLehman added this to the 6.13 milestone Sep 18, 2024

Merge branch 'develop' into refactor/deprecate-set-reaction-callbacks

aeb67bf

kodiakhq bot merged commit 6a3c25c into develop Sep 18, 2024

kodiakhq bot deleted the refactor/deprecate-set-reaction-callbacks branch September 18, 2024 16:39

KevLehman added a commit that referenced this pull request Sep 20, 2024

refactor: Remove old setreaction callbacks and use new after/before…

1e52d30

… callbacks (#33309)

abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024

refactor: Remove old setreaction callbacks and use new after/before…

3daffe8

… callbacks (#33309)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

refactor: Remove old `setreaction` callbacks and use new after/before callbacks#33309

refactor: Remove old `setreaction` callbacks and use new after/before callbacks#33309
kodiakhq[bot] merged 2 commits intodevelopfrom
refactor/deprecate-set-reaction-callbacks

KevLehman commented Sep 17, 2024 •

edited

Loading

Uh oh!

dionisio-bot bot commented Sep 17, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Sep 17, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Sep 17, 2024 •

edited

Loading

Uh oh!

codecov bot commented Sep 17, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

KevLehman commented Sep 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Uh oh!

dionisio-bot bot commented Sep 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Sep 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions bot commented Sep 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

KevLehman commented Sep 17, 2024 •

edited

Loading

dionisio-bot bot commented Sep 17, 2024 •

edited

Loading

changeset-bot bot commented Sep 17, 2024 •

edited

Loading

github-actions bot commented Sep 17, 2024 •

edited

Loading

codecov bot commented Sep 17, 2024 •

edited

Loading