Conversation
…ript for version management
…hance environment checks
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: deaefe9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis change lowers the minimum supported MongoDB version from 8.2 to 8.0 LTS across the entire codebase. It updates CI workflows, Docker configurations, server startup validation logic, and introduces a utility script for managing MongoDB version references. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adjusts the minimum supported MongoDB version for stability.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@apps/meteor/server/startup/serverRunning.ts`:
- Around line 87-93: The deprecation text in the semver check block (where
skipMongoDbDeprecationCheck, semver.satisfies(semver.coerce(mongoVersion)!,
'<8.0.0'), and showWarningBox are used) incorrectly claims MongoDB <8.0 "WILL
NOT BE SUPPORTED ON ROCKET.CHAT VERSION 8.0.0 AND GREATER" even though this code
runs in Rocket.Chat 8.x; update the warning message in that block to either: (A)
state that MongoDB <8.0 is deprecated now and will be removed in the next major
release (e.g., "DEPRECATED: MongoDB <8.0. Will be removed in Rocket.Chat
9.0.0"), or (B) say it is deprecated and support will be dropped in a future
major release (e.g., "DEPRECATED: MongoDB <8.0. Support will be removed in a
future release"), ensuring the strings built for msg reflect the corrected
wording so users on 8.x are not misled.
🧹 Nitpick comments (2)
apps/meteor/server/startup/serverRunning.ts (1)
95-122: Large block of commented-out code.This 28-line block of dead code hurts readability. Consider removing it entirely — it can always be recovered from version control if needed. As per coding guidelines, code comments in the implementation should be avoided.
scripts/set-mongo-version.mjs (1)
48-59:--helpexits with code 1 and writes to stderr.Conventional CLI behavior is to print help to stdout and exit with code 0 when the user explicitly requests
--help. Currently, both "no args" and--helpgo throughdie(), which uses stderr and a non-zero exit code. Consider separating help from error exits.Proposed fix
if (args.length === 0 || args.includes('--help') || args.includes('-h')) { - die( - [ + const isHelp = args.includes('--help') || args.includes('-h'); + const msg = [ 'Usage: node ./scripts/set-mongo-version.mjs <mongodbVersion> [--federation <federationMongoVersion>] [--compatible <v1,v2,...>] [--dry-run]', '', 'Examples:', ' node ./scripts/set-mongo-version.mjs 8.2', ' node ./scripts/set-mongo-version.mjs 8.2 --federation 8.0', ' node ./scripts/set-mongo-version.mjs 7.0 --dry-run', - ].join('\n'), - ); + ].join('\n'); + (isHelp ? process.stdout : process.stderr).write(`${msg}\n`); + process.exit(isHelp ? 0 : 1); }
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
.changeset/twelve-meals-sit.md.github/workflows/ci-test-e2e.yml.github/workflows/ci.ymlapps/meteor/server/startup/serverRunning.tsdocker-compose-ci.ymldocker-compose-local.ymlee/packages/federation-matrix/docker-compose.test.ymlpackage.jsonscripts/set-mongo-version.mjs
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation
Files:
apps/meteor/server/startup/serverRunning.ts
🧠 Learnings (2)
📚 Learning: 2026-01-17T01:51:47.764Z
Learnt from: tassoevan
Repo: RocketChat/Rocket.Chat PR: 38219
File: packages/core-typings/src/cloud/Announcement.ts:5-6
Timestamp: 2026-01-17T01:51:47.764Z
Learning: In packages/core-typings/src/cloud/Announcement.ts, the AnnouncementSchema.createdBy field intentionally overrides IBannerSchema.createdBy (object with _id and optional username) with a string enum ['cloud', 'system'] to match existing runtime behavior. This is documented as technical debt with a FIXME comment at apps/meteor/app/cloud/server/functions/syncWorkspace/handleCommsSync.ts:53 and should not be flagged as an error until the runtime behavior is corrected.
Applied to files:
apps/meteor/server/startup/serverRunning.ts
📚 Learning: 2025-09-19T15:15:04.642Z
Learnt from: rodrigok
Repo: RocketChat/Rocket.Chat PR: 36991
File: apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts:219-221
Timestamp: 2025-09-19T15:15:04.642Z
Learning: The Federation_Matrix_homeserver_domain setting in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts is part of the old federation system and is being deprecated/removed, so configuration issues with this setting should not be flagged for improvement.
Applied to files:
.changeset/twelve-meals-sit.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: 🔎 Code Check / Code Lint
- GitHub Check: 🔨 Test Unit / Unit Tests
- GitHub Check: 📦 Meteor Build (coverage)
- GitHub Check: 🔨 Test Storybook / Test Storybook
- GitHub Check: 🔎 Code Check / TypeScript
- GitHub Check: cubic · AI code reviewer
- GitHub Check: CodeQL-Build
- GitHub Check: CodeQL-Build
🔇 Additional comments (12)
.changeset/twelve-meals-sit.md (1)
1-6: LGTM!Changeset correctly marks both affected packages as patch updates with a clear description of the version policy change.
apps/meteor/server/startup/serverRunning.ts (1)
24-27: Skipping deprecation check in development and test modes looks reasonable.This prevents noisy warnings during local dev and CI runs.
scripts/set-mongo-version.mjs (2)
118-140:replaceAllOrThrowlogic is sound.Proper
lastIndexreset for global/sticky patterns, and the distinction between "pattern didn't match at all" (throw if required) vs. "pattern matched but replacement was identical" (no-op) is well handled.
161-258: Main execution block and file update orchestration look good.The dry-run support, progress output, and centralized version management across multiple config files is a solid approach. The regex patterns are appropriately tailored to each target file's format.
docker-compose-ci.yml (1)
178-178: LGTM!Default MongoDB version correctly updated to 8.0 while remaining overrideable via
MONGODB_VERSION.docker-compose-local.yml (1)
133-133: Good improvement: parameterized with env variable override.Previously hardcoded, now consistent with
docker-compose-ci.ymland overrideable viaMONGODB_VERSION.ee/packages/federation-matrix/docker-compose.test.yml (1)
122-123: LGTM!Parameterized with
MONGODB_FEDERATION_VERSIONand a sensible default, consistent with the separate federation version derivation logic inset-mongo-version.mjs..github/workflows/ci.yml (3)
161-162: LGTM — draft release notification updated tocompatibleMongoVersions: ["8.0"].Consistent with the version policy change.
551-552: LGTM — EE test jobs updated to MongoDB 8.0.Both
test-api-eeandtest-ui-eeconsistently use['8.0']for mongodb-version and'8.0'for coverage.Also applies to: 573-574
984-985: LGTM — final release notification updated consistently..github/workflows/ci-test-e2e.yml (1)
22-25: LGTM — default MongoDB version updated to 8.0 LTS.Aligns with the PR objective to target the long-term-support release instead of the short-lived 8.2 Rapid Release.
package.json (1)
31-31: New utility script for MongoDB version management looks good.Centralizing version updates via
set:mongo-versionis a solid approach to keep CI workflows, Docker Compose files, and other configs in sync. Verify the referenced script exists and handles edge cases (e.g., no arguments, invalid version format).
[approve_code_changes, request_verification]#!/bin/bash # Verify the script file exists and check its basic structure fd 'set-mongo-version.mjs' --type f echo "---" cat scripts/set-mongo-version.mjs 2>/dev/null | head -40
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #38596 +/- ##
========================================
Coverage 70.45% 70.45%
========================================
Files 3174 3174
Lines 111005 111004 -1
Branches 20000 20019 +19
========================================
+ Hits 78207 78208 +1
+ Misses 30758 30755 -3
- Partials 2040 2041 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
📦 Docker Image Size Report📈 Changes
📊 Historical Trend---
config:
theme: "dark"
xyChart:
width: 900
height: 400
---
xychart
title "Image Size Evolution by Service (Last 30 Days + This PR)"
x-axis ["11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 22:18", "12/17 21:04", "12/18 23:12", "12/19 23:27", "12/20 21:03", "12/22 18:54", "12/23 16:16", "12/24 19:38", "12/25 17:51", "12/26 13:18", "12/29 19:01", "12/30 20:52", "02/12 03:41", "02/12 13:20 (PR)"]
y-axis "Size (GB)" 0 --> 0.5
line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
line "omnichannel-transcript-service" [0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
line "queue-worker-service" [0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
line "rocketchat" [0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]
Statistics (last 30 days):
ℹ️ About this reportThis report compares Docker image sizes from this build against the
Updated: Thu, 12 Feb 2026 13:20:23 GMT |
Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>
Co-authored-by: ggazzo <5263975+ggazzo@users.noreply.github.com>
…ecation-warning Fix MongoDB <8.0 deprecation warning for version 8.x
ggazzo
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
We initially documented MongoDB 8.2 as the minimum supported version. However, MongoDB 8.2 belongs to the Rapid Release channel, which has a short support lifecycle (approximately three months).
To avoid relying on short-lived releases and to provide a more stable and predictable support matrix, we have adjusted the minimum supported MongoDB version to MongoDB 8.
With this change, we explicitly commit that this Rocket.Chat version is tested and guaranteed to work with MongoDB 8.x.
https://rocketchat.atlassian.net/browse/CORE-1814
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
Summary by CodeRabbit