Conversation
Co-authored-by: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com>
Co-authored-by: Tasso Evangelista <2263066+tassoevan@users.noreply.github.com>
Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com>
Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com>
…m is encrypted (#38279) Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com>
…se the new link function for URL formatting.
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
#38796) Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
#38796) Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz> Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: sampaiodiego <8591547+sampaiodiego@users.noreply.github.com> Co-authored-by: Diego Sampaio <chinello@gmail.com>
🦋 Changeset detectedLatest commit: d97ea5f The changes in this PR will be included in the next version bump. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Important Review skippedToo many files! This PR contains 281 files, which is 131 over the limit of 150. You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 1173 files
Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/actions/docker-image-size-tracker/action.yml">
<violation number="1" location=".github/actions/docker-image-size-tracker/action.yml:305">
P2: When there’s no baseline, the compare step exits before setting the new `failed` output, so `steps.compare.outputs.failed` is empty. Set it to `false` in the early-exit path to keep outputs consistent.</violation>
</file>
<file name="apps/meteor/app/2fa/server/twoFactorRequired.ts">
<violation number="1" location="apps/meteor/app/2fa/server/twoFactorRequired.ts:23">
P2: The inner function has no type annotations for `this` or `args`, making them implicitly `any`. Combined with the `as` assertion on the return, this bypasses TypeScript's type checking inside the function body. Consider annotating `this` as `AuthenticatedContext` and `args` as `any[]` to preserve internal type safety while keeping the external signature via the cast.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| echo "No baseline available" | ||
| echo "size-diff=0" >> $GITHUB_OUTPUT | ||
| echo "size-diff-percent=0" >> $GITHUB_OUTPUT | ||
| echo "comment-triggered=false" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
P2: When there’s no baseline, the compare step exits before setting the new failed output, so steps.compare.outputs.failed is empty. Set it to false in the early-exit path to keep outputs consistent.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/actions/docker-image-size-tracker/action.yml, line 305:
<comment>When there’s no baseline, the compare step exits before setting the new `failed` output, so `steps.compare.outputs.failed` is empty. Set it to `false` in the early-exit path to keep outputs consistent.</comment>
<file context>
@@ -272,13 +290,19 @@ runs:
echo "No baseline available"
echo "size-diff=0" >> $GITHUB_OUTPUT
echo "size-diff-percent=0" >> $GITHUB_OUTPUT
+ echo "comment-triggered=false" >> $GITHUB_OUTPUT
cat > report.md << 'EOF'
</file context>
| echo "comment-triggered=false" >> $GITHUB_OUTPUT | |
| echo "comment-triggered=false" >> $GITHUB_OUTPUT | |
| echo "failed=false" >> $GITHUB_OUTPUT |
| ): (this: Meteor.MethodThisType, ...args: Parameters<TFunction>) => Promise<ReturnType<TFunction>> { | ||
| return async function (this: Meteor.MethodThisType, ...args: Parameters<TFunction>): Promise<ReturnType<TFunction>> { | ||
| ) => | ||
| async function (this, ...args) { |
There was a problem hiding this comment.
P2: The inner function has no type annotations for this or args, making them implicitly any. Combined with the as assertion on the return, this bypasses TypeScript's type checking inside the function body. Consider annotating this as AuthenticatedContext and args as any[] to preserve internal type safety while keeping the external signature via the cast.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/meteor/app/2fa/server/twoFactorRequired.ts, line 23:
<comment>The inner function has no type annotations for `this` or `args`, making them implicitly `any`. Combined with the `as` assertion on the return, this bypasses TypeScript's type checking inside the function body. Consider annotating `this` as `AuthenticatedContext` and `args` as `any[]` to preserve internal type safety while keeping the external signature via the cast.</comment>
<file context>
@@ -3,11 +3,24 @@ import { Meteor } from 'meteor/meteor';
-): (this: Meteor.MethodThisType, ...args: Parameters<TFunction>) => Promise<ReturnType<TFunction>> {
- return async function (this: Meteor.MethodThisType, ...args: Parameters<TFunction>): Promise<ReturnType<TFunction>> {
+) =>
+ async function (this, ...args) {
if (!this.userId) {
throw new Meteor.Error('error-invalid-user', 'Invalid user', { method: 'twoFactorRequired' });
</file context>
| async function (this, ...args) { | |
| async function (this: AuthenticatedContext, ...args: any[]) { |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #38848 +/- ##
==========================================
- Coverage 70.79% 70.55% -0.25%
==========================================
Files 3142 3187 +45
Lines 108949 112613 +3664
Branches 19620 20390 +770
==========================================
+ Hits 77131 79454 +2323
- Misses 29820 31101 +1281
- Partials 1998 2058 +60
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
20 participants
You can see below a preview of the release change log:
8.2.0
Engine versions
22.16.01.43.58.01.60.0Minor Changes
(#38099) Adds file metadata to the Apps.Engine for messages with multiple files
(#38173) Adds a new endpoint to delete uploaded files individually
(#38356) Creates a new setting with an extra layer of validation to restrict the usage of federation to only users with a validated email address that matches the configured federation domain.
(#38044) Adds configurable SSRF validation for HTTP calls made from server
(#38532) Standardizes the display of username with
@beforePatch Changes
(#38374) Fixes an issue where apps logs were being lost in nested requests
(#38283) Fixes an issue with encrypted room's message previews on the sidebar not always being properly decrypted
(#37776) Prevents over-assignment of omnichannel agents beyond their max chats limit in microservices deployments by serializing agent assignment with explicit user-level locking.
(#35971 by @JASIM0021) Fixes an issue where the Resend Verification Email could be abused to spam mail servers
(#38653 by @copilot-swe-agent) Fixes an issue where messages could be sent to archived rooms via the API
(#38794 by @copilot-swe-agent) Fixes preview generation for vendor-specific image formats like
.dwg(AutoCAD) files. Files with MIME types such asimage/vnd.dwgandimage/vnd.microsoft.iconare now excluded from preview generation as they cannot be processed by the Sharp image library, preventing failed preview attempts.(#38796 by @copilot-swe-agent) Fixes an issue where regular users could start video conference calls in read-only channels bypassing message restrictions
(#38379) Fixes association of encrypted messages and encrypted files, so that if one of them is removed, the other gets removed as well.
(#38616) Fixes device management logout not redirecting to login page.
(#37356 by @MrKalyanKing) Fixes issue that caused Outgoing Webhook Retry Count to not be a number
(#38491) Fixes an issue where the camera could stay on after closing the video recording modal.
(#38267) Fixes an issue where web clients could remain with a stale slashcommand list during a rolling workspace update
(#38319) Fixes incoming webhook integrations not receiving parsed JSON from x-www-form-urlencoded payload field.
(#38579 by @ScriptShah) Fixes an issue where managers table loading skeleton column mismatch with headers
(#38318) Fixes room header toolbar different spacing on Options menu
(#38366) Fixes the
sortparameter validation on/api/v1/audit.settingsendpoint to accept string format.(#38279) Fixes issue when trying to create an unencrypted discussion when a parent channel is encrypted
(#38262) Fixes an issue with the sidebar message preview (extended layout) showing
undefinedwhen the message has no previewable content(#38282) Fixes dismissed banner popups reappearing after server restart.
(#38292) Fixes room message export to correctly handle messages with multiple files.
(#38376) Fix a validation issue in the
livechat/custom-fields.saveendpoint(#38415) Fixes delete message permission check in read-only rooms to validate the deleting user's unmuted status instead of the message sender's
(#38265) Fixes endpoints
omnichannel/contacts.updateandomnichannel/contacts.conflictswhere the contact manager field could not be cleared.(#38596) Adjusts the minimum supported MongoDB version from 8.2 (Rapid Release with short support lifecycle) to 8, ensuring stable and long-term compatibility
(#38568) Adds automatic cleanup of statistics collection with 1-year retention via TTL index.
Updated dependencies [bbc1489, 1182145, d3758a7, 398fca0, 098f0a7, fbc4935, e57f158, 11e1c51, 88da141, 1c47458, 75d089c, a75e1f1, 3b003e6, 87faec1, d6ef0db, 508b4a1, 379c2b2, 562d5ce, 123aebe]: