Fix for keeping a room hidden after activity

[kable-wilmoth]

@RocketChat/core

Currently you can mark a room as hidden and it will be removed from your channel list, even after a browser refresh. BUT, if any activity occurs in this hidden channel, it no longer remains hidden.

This fix keeps the channel hidden w/ normal channel activity. Other things (notification settings) will make the room visible (mentions, etc.) but that is a different concern.

[kable-wilmoth]

setAlertForRoomIdExcludingUserId is only called in one place and there was no expectation of the side effect of updating the room 'open' property.

[engelgabriel]

This was not a bug :) it was intended. If you want a different behaviour, we need to make it configurable.

[engelgabriel]

This was not a bug :) it was intended. If you want a different behaviour, we need to make it configurable.

[kable-wilmoth]

Oh, I had no idea. I couldn't find any docs about it and the code and comments didn't make it obvious. So the current behavior just hides it until there is activity. This was the intent? So I assume people probably hid rooms that they were a member of but are not very active?
I will look into end user configurations for this. Any pointers on where to learn about this in the code? Any suggestions for the name of this configuration?
Show hidden rooms when unread messages? (default true)

[engelgabriel]

We copied the behavior from Skype at the time. Maybe we could change the wording to CLOSE rather than HIDE?

[engelgabriel]

Hummm.. On a second thought, CLOSE may be even more confusing...

[kable-wilmoth]

My specific use case for our team.
Our company has standardized on Rocket, but a lot of teams still use Slack (especially for the mobile client/speed). So these teams have their channels 'bridged' so that Rocket users can also participate in them.
So for these teams, their primary usage is through Slack, but they need to check Rocket throughout the day for other corporate communications out their team.
Their slack channels are bridged into rocket, so even though they have 'read' all the team channels throughout the day, in Rocket, they have all their channels flagged w/ messages and it is really annoying.
So they have tried to use the 'hide' channel feature, because they really don't interact with those channels via Rocket. This works, until someone posts a message, then the channel shows back up w/ lots of messages marked as un-read.
With my change, this use case works great, but I do understand it wasn't as designed and the SlackBridge is a corner case.

What did you think of my suggested setting?
Show hidden rooms when unread messages? (default true)

[marceloschmidt]

@kable-wilmoth I like your proposal of "Show hidden rooms when unread messages"

[marceloschmidt]

I would love to see the suggested changes for "Show hidden rooms when unread messages"

[engelgabriel]

Hi @kable-wilmoth

I know your latest PRs were open for far too long, but we were busy with implementing the new UX and were trying to catch up, so I am sorry for that. Having said that, is there any reason why you closed all the open PRs?

[lindoelio]

I thought it was already implemented in the current version, but I was wrong :-) I can increment the parameter in the settings.

[lindoelio]

Hey guys! Let me know what you think about my suggestions for this feature on PR #8053.
@kable-wilmoth @marceloschmidt @engelgabriel