Skip to content

Fix for keeping a room hidden after activity #6299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kable-wilmoth wants to merge 1 commit into from
Closed

Fix for keeping a room hidden after activity #6299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/rocketchat-lib/server/lib/notifyUsersOnMessage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ RocketChat.callbacks.add('afterSaveMessage', function(message, room) {

// Update all other subscriptions to alert their owners but witout incrementing
// the unread counter, as it is only for mentions and direct messages
// If a room is hidden, it will remain hidden
RocketChat.models.Subscriptions.setAlertForRoomIdExcludingUserId(message.rid, message.u._id);

return message;
Expand Down
1 change: 0 additions & 1 deletion packages/rocketchat-lib/server/models/Subscriptions.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,6 @@ class ModelSubscriptions extends RocketChat.models._Base
update =
$set:
alert: true
open: true

Copy link
Author

@kable-wilmoth kable-wilmoth Mar 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setAlertForRoomIdExcludingUserId is only called in one place and there was no expectation of the side effect of updating the room 'open' property.

Copy link
Member

@engelgabriel engelgabriel Mar 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not a bug :) it was intended. If you want a different behaviour, we need to make it configurable.

return @update query, update, { multi: true }

Expand Down