[FIX] Wrong file name when upload to AWS S3#8296
Merged
engelgabriel merged 1 commit intodevelopfrom Sep 25, 2017
Merged
Conversation
engelgabriel
approved these changes
Sep 25, 2017
rodrigok
pushed a commit
that referenced
this pull request
Sep 26, 2017
[FIX] Wrong file name when upload to AWS S3
|
@gdelavald : it still missing extension when download file from macOSX client. |
Contributor
|
Did this perhaps cause this regression: #8584 |
Contributor
|
Yeah it did, You need to quote the filename. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #8265