[FIX] AmazonS3: Quote file.name for ContentDisposition for files with commas

[xenithorb]

Adds quotes around the filename attribute.

See:

• Filenames with commas (clipboard uploads) do not display on S3 File Upload backend for chromium-based clients (electron) [MULTIPLE_CONTENT_DISPOSITION] #8584
• https://stackoverflow.com/questions/38320996/s3-downloading-images-with-comma-in-filename-results-in-neterr-response-heade

Fixes #8584

@RocketChat/core

[xenithorb]

The quicker this gets out the better because I have no idea how to retroactively fix these attributes because they're stored IN S3.

This was caused by #8296, which introduced the Content-Distribution attribute in order to de-obfuscate names during download, the problem is/was that the ${ file.name } item wasn't quoted and produced double headers because of the comma in the file names due to a amazon S3 bug.

Firefox apparently happily ignores the double headers, but chromium and all chromium/blink based browsers do not and throw up a ERR_RESPONSE_HEADERS_MULTIPLE_CONTENT_DISPOSITION error, causing the image to not be displayed for those type of clients. This CAN be fixed by retroactively adding quotes around the filename ( so filename=a , b would need to be changed to filename="a , b" ). The change here is doing this after the fact, but does not fix the images that will be brokenly displayed since #8296 was deployed.

[xenithorb]

Also see this badly placed comment, that I totally did not see until after the fact, lol. : 3e72e0c#commitcomment-25082377

[geekgonecrazy]

👍 this only makes sense

A comma in there with out quotes would mess up parsing and cause all kinds of issues especially with s3.

[xenithorb]

Bear in mind one thing worth nothing that I just thought of are files with double quotes now.. Not exactly sure how that will be handled (i.e. escaped properly), but it should be a lesser occurrence than other odd chars in file names.