[FIX] Use encodeURI in AmazonS3 contentDisposition file.name to prevent fail#9024
Merged
rodrigok merged 2 commits intoRocketChat:developfrom Dec 7, 2017
paulovitin:amazons3-special-chars
Merged
[FIX] Use encodeURI in AmazonS3 contentDisposition file.name to prevent fail#9024rodrigok merged 2 commits intoRocketChat:developfrom paulovitin:amazons3-special-chars
rodrigok merged 2 commits intoRocketChat:developfrom
paulovitin:amazons3-special-chars
Conversation
Adds: - encodeURI in AmazonS3 store to allow special chars in file name;
|
|
geekgonecrazy
approved these changes
Dec 7, 2017
Contributor
geekgonecrazy
left a comment
geekgonecrazy
left a comment
There was a problem hiding this comment.
LGTM 👍 The quotes were supposed to help with this, but then makes quotes themselves in filenames break 😁
Contributor
|
@paulovitin thanks for your contribution! @xenithorb this should help finish your fix from #8593 so you might be interested in this one :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #8752
Adds: