fix(fuselage-tokens): incorrect color tokens on Button's success variant #1471
Merged
aleksandernsilva merged 3 commits intomainfrom Oct 25, 2024
Merged
fix(fuselage-tokens): incorrect color tokens on Button's success variant #1471aleksandernsilva merged 3 commits intomainfrom
aleksandernsilva merged 3 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: a4586be The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
juliajforesti
requested changes
Oct 23, 2024
juliajforesti
approved these changes
Oct 23, 2024
Co-authored-by: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com>
aleksandernsilva
force-pushed
the
fix/button-colors
branch
from
66675c4 to
a4586be
Compare
Merged
dougfabris
pushed a commit
that referenced
this pull request
Oct 29, 2024
…ant (#1471) Co-authored-by: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com>
dougfabris
pushed a commit
that referenced
this pull request
Oct 29, 2024
…ant (#1471) Co-authored-by: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR fixes Button's success variant, which was using the incorrect color tokens. This was affecting the light theme in particular.
Before:
After:
Issue(s)
Further comments
VOIP-118