BUG: absolute value of the rail button forces #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
MateusStano
approved these changes
Sep 11, 2023
Member
MateusStano
left a comment
MateusStano
left a comment
There was a problem hiding this comment.
Seems good enough to me. Great PR!
Member
Author
|
Nice catch in the last commit 7685955 @phmbressan , I appreciate it a lot. Merging it into beta/v1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
Pull request checklist
Code base additions (for bug fixes / features):
black rocketpy) has passed locally and any fixes were madepytest --runslow) have passed locallyWhat is the current behavior?
The forces at the rail buttons can be sctricly negative, therefore the arguments that compute the max forces in the rail buttons will return exactly the opposite of what we usually want: the least intense load.
What is the new behavior?
The Function class now can calculate the maximum (and min) absolute value of a function.
Does this introduce a breaking change?
Other information