Skip to content

BUG: absolute value of the rail button forces #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gui-FernandesBR merged 4 commits into from
Sep 15, 2023
Merged

BUG: absolute value of the rail button forces #407

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f06a142
FIX: absolute value of the rail button forces
Gui-FernandesBR Sep 9, 2023
279574f
Fix code style issues with Black
lint-action Sep 9, 2023
b3a5984
MAINT: drop Function.max_absolute properties
Gui-FernandesBR Sep 15, 2023
7685955
FIX: consider only rail button force at max calc.
phmbressan Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions rocketpy/Flight.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2623,22 +2623,22 @@ def rail_button2_shear_force(self):
@property
def max_rail_button1_normal_force(self):
"""Maximum upper rail button normal force, in Newtons."""
return self.rail_button1_normal_force.max
return np.abs(self.rail_button1_normal_force.y_array).max()

@property
def max_rail_button1_shear_force(self):
"""Maximum upper rail button shear force, in Newtons."""
return self.rail_button1_shear_force.max
return np.abs(self.rail_button1_shear_force.y_array).max()

@property
def max_rail_button2_normal_force(self):
"""Maximum lower rail button normal force, in Newtons."""
return self.rail_button2_normal_force.max
return np.abs(self.rail_button2_normal_force.y_array).max()

@property
def max_rail_button2_shear_force(self):
"""Maximum lower rail button shear force, in Newtons."""
return self.rail_button2_shear_force.max
return np.abs(self.rail_button2_shear_force.y_array).max()

@funcify_method(
"Time (s)", "Horizontal Distance to Launch Point (m)", "spline", "constant"
Expand Down