eliminate subunits for forints#679
Merged
antstorm merged 1 commit intoRubyMoney:masterfrom Jan 25, 2017
Merged
Conversation
Contributor
|
@Azdaroth thanks! |
roshats
added a commit
to SoftSwiss/money
that referenced
this pull request
Jan 15, 2018
In RubyMoney#679 `subunit_to_unit` for HUF was change from 100 to 1. According to [ISO](https://www.iso.org/iso-4217-currency-codes.html) (https://www.currency-iso.org/dam/downloads/lists/list_one.xml) and [wiki](https://en.wikipedia.org/wiki/Hungarian_forint) `subunit_to_unit` for HUF is 100. It is important to have HUF configured according to ISO because usually cents is used in communication between services. Also, https://github.com/RubyMoney/money-rails gem recommends to store amount in cents.
roshats
added a commit
to SoftSwiss/money
that referenced
this pull request
Jan 15, 2018
In RubyMoney#679 `subunit_to_unit` for HUF was change from 100 to 1. According to [ISO](https://www.iso.org/iso-4217-currency-codes.html) (https://www.currency-iso.org/dam/downloads/lists/list_one.xml) and [wiki](https://en.wikipedia.org/wiki/Hungarian_forint) `subunit_to_unit` for HUF is 100. It is important to have HUF configured according to ISO because usually cents is used in communication between services. Also, https://github.com/RubyMoney/money-rails gem recommends to store amount in cents.
This was referenced Jan 15, 2018
Closed
roshats
added a commit
to SoftSwiss/money
that referenced
this pull request
Jan 15, 2018
In RubyMoney#679 `subunit_to_unit` for HUF was change from 100 to 1. According to [ISO](https://www.iso.org/iso-4217-currency-codes.html) (https://www.currency-iso.org/dam/downloads/lists/list_one.xml) and [wiki](https://en.wikipedia.org/wiki/Hungarian_forint) `subunit_to_unit` for HUF is 100. It is important to have HUF configured according to ISO because usually cents is used in communication between services. Also, https://github.com/RubyMoney/money-rails gem recommends to store amount in cents.
matid
added a commit
to matid/money
that referenced
this pull request
May 5, 2024
Subunits of Hungarian forint are no longer in circulation and were eliminated in RubyMoney#679. However, ISO continues to treat HUF as a two decimal place currency. This can be confirmed against the standard here: https://www.six-group.com/dam/download/financial-information/data-center/iso-currrency/lists/list-one.xml To align Money with the ISO 4217 standard, this change restores original behavior of considering HUF a 2 decimal point currency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #677