Skip to content

HUF has exponent of 2#959

Closed
mrexox wants to merge 2 commits intoRubyMoney:masterfrom
mrexox:fix-precision-for-HUF
Closed

HUF has exponent of 2#959
mrexox wants to merge 2 commits intoRubyMoney:masterfrom
mrexox:fix-precision-for-HUF

Conversation

@mrexox
Copy link
Copy Markdown

@mrexox mrexox commented Nov 17, 2020

Actually it has exponent of 2, see: https://en.wikipedia.org/wiki/Hungarian_forint

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 17, 2020

Coverage Status

Coverage remained the same at 99.863% when pulling 3694768 on mrexox:fix-precision-for-HUF into 399d65f on RubyMoney:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.002%) to 99.865% when pulling 7c05d6f on mrexox:fix-precision-for-HUF into 399d65f on RubyMoney:master.

1 similar comment
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.002%) to 99.865% when pulling 7c05d6f on mrexox:fix-precision-for-HUF into 399d65f on RubyMoney:master.

@antstorm
Copy link
Copy Markdown
Contributor

@mrexox any comments on #677? Seems like we did change it to 1 about 4 years ago…

@ct-clearhaus
Copy link
Copy Markdown
Contributor

There's also #742 🙂

@mrexox
Copy link
Copy Markdown
Author

mrexox commented Nov 19, 2020

Wow, it seems that this change can now break something. I've redefined HUF in initializer and it works just fine, but there is something that must be done with this issue.

You can close this PR if you wish.

@mrexox mrexox closed this Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants