Skip to content
This repository was archived by the owner on Jun 7, 2023. It is now read-only.

Conversation

@zihan21206
Copy link
Contributor

Updated the custom element used for horizontal parsons input and removed the unused dependencies, such as Quill.

Also used terser to reduce the code size of the custom element.

@bnmnetp
Copy link
Member

bnmnetp commented Dec 27, 2022

Hi,

The file that you call micro-parsons.js looks like a minified version of Sortable 1.14.0. ??

If that is the case then you should npm install sortable so that it is added and tracked through the package.json file.

Since we can't edit it, there is no reason for us to have it in our repo other than as a third party dependency.

@zihan21206
Copy link
Contributor Author

zihan21206 commented Dec 27, 2022 via email

@bnmnetp
Copy link
Member

bnmnetp commented Dec 27, 2022

OK, I see....

I think that what we want to work toward -- not right now, as we prepare for the semester -- is that the micro-parsons-element should be released/published using npm with its own versions. Then in Runestone we install and manage the micro-parsons-element as a third party library.

It really does us no good to have a minified js file in our repo as we can't edit it.

We will need to document this so that when someone else needs to add something to micro-parsons they will know that part of the code is contained in a whole different repository.

@zihan21206
Copy link
Contributor Author

Thanks for your help!

I added documentation in the js file for hparsons directory pointing edits to the micro-parsons-element repository, and I also created an issue (#1379) referring to this PR and addressing the future plan for replacing the minimized js file with the published package.

@bnmnetp bnmnetp merged commit 796d415 into RunestoneInteractive:master Jan 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants