Skip to content
This repository was archived by the owner on Jun 7, 2023. It is now read-only.

Conversation

@presnick
Copy link
Contributor

@presnick presnick commented Sep 3, 2016

May want to resolve other PR from me first, so that this one will be cleaner,

presnick and others added 30 commits September 15, 2015 21:51
Conflicts:
	runestone/common/css/runestone-custom-sphinx-bootstrap.css
Conflicts:
	runestone/server/componentdb.py
Conflicts:
	runestone/server/componentdb.py
TODO: make it easier to refactor from this basis, CSS to fix formatting to be its own and static with other 'problem set' problems.
This could be cleaned up/should change as evolved.
@presnick
Copy link
Contributor Author

A bunch more stuff has accumulated here now. I think it would be worth trying to merge this soon.

@presnick
Copy link
Contributor Author

In order for this to work, need one model change in RunestoneInteractive/RunestoneServer#869

env.activecodecounter += 1
self.options['name'] = self.arguments[0].strip()

self.options['basecourse'] = self.state.document.settings.env.config.html_context.get('basecourse', "unknown")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed? set in runestonedirectives/init

self.options['qnumber'] = self.getNumber()

self.options['divid'] = self.arguments[0]
self.options['basecourse'] = self.state.document.settings.env.config.html_context.get('basecourse', "unknown")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need this.

@presnick
Copy link
Contributor Author

presnick commented Oct 6, 2016

Should be ready for merge now.

@bnmnetp bnmnetp merged commit 3ce03a3 into RunestoneInteractive:master Oct 7, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants