This repository was archived by the owner on Jun 7, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 223
Assignment directive #264
Merged
bnmnetp
merged 86 commits into
RunestoneInteractive:master
from
presnick:assignment_directive
Oct 7, 2016
Merged
Assignment directive #264
bnmnetp
merged 86 commits into
RunestoneInteractive:master
from
presnick:assignment_directive
Oct 7, 2016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ters in it; update varnames to be clearer
Conflicts: runestone/common/css/runestone-custom-sphinx-bootstrap.css
Conflicts: runestone/server/componentdb.py
Conflicts: runestone/server/componentdb.py
TODO: make it easier to refactor from this basis, CSS to fix formatting to be its own and static with other 'problem set' problems.
This could be cleaned up/should change as evolved.
Reformat subchapter appearance and indent for more neatness
…; updates to assignment directive
This reverts commit cfd993f.
Contributor
Author
|
A bunch more stuff has accumulated here now. I think it would be worth trying to merge this soon. |
Contributor
Author
|
In order for this to work, need one model change in RunestoneInteractive/RunestoneServer#869 |
Conflicts: runestone/activecode/js/activecode.js
Conflicts: runestone/server/componentdb.py
presnick
commented
Oct 6, 2016
runestone/activecode/activecode.py
Outdated
| env.activecodecounter += 1 | ||
| self.options['name'] = self.arguments[0].strip() | ||
|
|
||
| self.options['basecourse'] = self.state.document.settings.env.config.html_context.get('basecourse', "unknown") |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed? set in runestonedirectives/init
runestone/assess/assessbase.py
Outdated
| self.options['qnumber'] = self.getNumber() | ||
|
|
||
| self.options['divid'] = self.arguments[0] | ||
| self.options['basecourse'] = self.state.document.settings.env.config.html_context.get('basecourse', "unknown") |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't need this.
…lly in runestonedirective.py
Contributor
Author
|
Should be ready for merge now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May want to resolve other PR from me first, so that this one will be cleaner,