autograde type comes from assignment_questions; getassignmentgrade looks in new location first #869
Conversation
| # try: | ||
| # db.executesql('''alter table questions add constraint name_bc_unique UNIQUE(name, base_course)''') | ||
| # except: | ||
| # pass |
There was a problem hiding this comment.
If this is commented out, then new installations will not get this constraint which we want to preseve? Why comment it out?
There was a problem hiding this comment.
I was getting an error when there is another migration to be done later in the file. The attempt to run db.executesql seems to poison the session objec that will be needed later, so try/except wasn't sufficient. (Also seems inefficient to keep running this query every time web2py loads. Isn't there a way to get this constraint through web2py define_table?)
There was a problem hiding this comment.
According to everything I could find in the web2py docs, you cannot create a constraint like this as part of the regular syntax for defining a table.
There was a problem hiding this comment.
Hmm, well we need to do something other than this, because it breaks things when there's another migration to be done.
|
|
||
| # dispatch on grading_type; if none specified, can't autograde | ||
| if question.autograde == 'unittest': | ||
| if autograde == 'unittest': |
There was a problem hiding this comment.
If an instructor is following a grading path of chapter --> question will this still work? Why the change from autograde to question.autograde ??
There was a problem hiding this comment.
I wasn't aware of that grading path. I don't think I implemented autograde for anything other than assignments. What do you have in mind?
Note: we discussed last week and decided the decision about whether particular questions should be autograded should be a property of the assignment_question, not the question.
There was a problem hiding this comment.
We talked about it this summer. The path is where the instructor selects Chapter for the first column, a question from the chapter for the second, and then student in the third column.
There was a problem hiding this comment.
OK. But I think that's just not implemented at this time. I suggest that we make that a to-do item. (Unless you think it's actually working and this will break it.)
There was a problem hiding this comment.
I think I may have been confused about the recent conversation or maybe I'm confused by the values associated with the autograde column.
- Whether or not a question can be autograded is one thing. I can see where this would be useful at the assignment level. If you try to autograde an entire assignment there might be questions that are autogradeable and questions that are not. But, if a question is autogradeable at all isn't it always autogradeable?
- How a question is autograded seems like a separate idea, and does not seem likely to change as the autograde method is kind of encompassed by the kind of question it is in the first place.
| else: | ||
| results['status'] = 'failed' | ||
| results['info'] = 'no row' | ||
| return json.dumps(results) |
There was a problem hiding this comment.
This looks like it is unrelated to the purpose of the PR -- but seems like valid cleanup??
There was a problem hiding this comment.
Yeah, I must have encountered some issue where I needed that for debugging purposes.
…otal for single student
2 participants
No description provided.