ascon-aead: Add ascon sponge Zeroize feature#527
Merged
sebastinas merged 1 commit intoRustCrypto:masterfrom Oct 24, 2023
Merged
ascon-aead: Add ascon sponge Zeroize feature#527sebastinas merged 1 commit intoRustCrypto:masterfrom
sebastinas merged 1 commit intoRustCrypto:masterfrom
Conversation
aewag
force-pushed
the
add-zeroize-ascon-aead
branch
from
a0eddd9 to
cae7093
Compare
aewag
force-pushed
the
add-zeroize-ascon-aead
branch
from
cae7093 to
04ea8db
Compare
sebastinas
reviewed
Jul 27, 2023
aewag
force-pushed
the
add-zeroize-ascon-aead
branch
from
7cccb47 to
98d529f
Compare
newpavlov
reviewed
Oct 23, 2023
aewag
force-pushed
the
add-zeroize-ascon-aead
branch
3 times, most recently
from
ef647cb to
0fc86bd
Compare
Not zeroizing the state may expose the private key.
aewag
force-pushed
the
add-zeroize-ascon-aead
branch
from
0fc86bd to
d533559
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not zeroizing the state may expose the private key.
As the MSRV is below 1.60 the
dep:syntax is not available. Hence, the second featuresponge-zeroize. Any other suggestions to handle it better are welcome.This relies on RustCrypto/sponges#57 and a new release of the
asconcrate.