ascon: Add Drop & ZeroizeOnDrop for State#57
Merged
sebastinas merged 1 commit intoRustCrypto:masterfrom May 23, 2023
Merged
Conversation
This was referenced May 19, 2023
sebastinas
suggested changes
May 20, 2023
Not zeroizing the state allows to recover any squeezed output. This is because the `ascon` permutations can be inversed. Hence, access to the complete state allows to perform this operation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not zeroizing the state allows to recover secrets, either by the inverse permutation or by reversing calculations performed with the state.
I had to drop the impl of
Copy, because of the impl ofDrop. TheCopytrait was only used within a test.PRs regarding ascon-hash and ascon-aead.