Sealed trait to make (De|En)capsulationKeys more usable#81
Closed
jmwample wants to merge 1 commit intoRustCrypto:masterfrom
Closed
Sealed trait to make (De|En)capsulationKeys more usable#81jmwample wants to merge 1 commit intoRustCrypto:masterfrom
(De|En)capsulationKeys more usable#81jmwample wants to merge 1 commit intoRustCrypto:masterfrom
Conversation
…ges without exposing KemParams Publicly
Member
|
In the latest prereleases of Do those do what you need in a generic context? Ideally I would like to get rid of a lot of the bespoke traits that various crates in this repo have which don't interoperate with each other. |
Contributor
Author
|
I am going to close this PR and try your suggestion. The project has been on the back-burner for some time and when I circle back around I will likely rework around a number of other things. Thank you for checking back in. |
Member
|
I realized there may be one gap still: RustCrypto/traits#2213 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make is possible to wrap
kem::(De|En)capsulationKeyin external packages without exposingKemParamspublicly.Instead of making
KemParamspublic and allowing external types to implement the interface, I have added a public traitParamswhich hasKemParamsas a public supertrait whose name is not publicly exported (private module). Rust API GuidelinesThis makes it possible to do things like:
This is more convenient than working with
<P as KemCore>::DecapsulationKey.Closes #65