Merged
Conversation
newpavlov
approved these changes
Jan 22, 2026
Member
newpavlov
left a comment
newpavlov
left a comment
There was a problem hiding this comment.
Please do not forget to update the changelog.
tarcieri
force-pushed
the
crypto-common/add-key-export-trait
branch
from
0ff46b3 to
416dfd8
Compare
Adds a companion trait to `KeyInit*` for exporting a key to a byte array sized according to `KeySizeUser`. This is needed when generating e.g. asymmetric secret keys types using the `Generate` trait and it returns an actual key type (e.g. `SigningKey`, `DecryptionKey`, `DecapsulationKey`) as opposed to its serialized byte representation.
tarcieri
force-pushed
the
crypto-common/add-key-export-trait
branch
from
416dfd8 to
419d83c
Compare
Member
Author
|
Removed the |
Merged
newpavlov
pushed a commit
that referenced
this pull request
Feb 4, 2026
### Added - Sealed `BlockSizes` trait implemented for types from `U1` to `U255` ([#1172]) - `SerializableState` trait under `hazmat` module ([#1369]) - `OutputSize` type alias ([#1533]) - `IvState` trait ([#1636]) - `core::error::Error` impls for error types ([#1660]) - `Generate` trait as a common RNG API ([#2096], [#2145]) - `TryKeyInit` trait ([#2097]) - Re-export `getrandom` ([#2152]) - `KeyExport` trait ([#2213]) ### Changed - Replaced `generic-array` with `hybrid-array` ([#1319], [#1976]) - `BlockUser::BlockSize` is now bounded by the `BlockSizes` trait - Edition changed to 2024 and MSRV bumped to 1.85 ([#1759]) - `generate_*` methods on `KeyInit` and `KeyIvInit` traits have been deprecated in favor of the new `Generate` trait ([#2162]) - Bump `rand_core` to v0.10 ([#2250]) - Bump `getrandom` to v0.4 ([#2258]) ### Removed - `std` feature ([#1680]) [#1172]: #1172 [#1319]: #1319 [#1369]: #1369 [#1533]: #1533 [#1636]: #1636 [#1660]: #1660 [#1680]: #1680 [#1759]: #1759 [#1976]: #1976 [#2096]: #2096 [#2097]: #2097 [#2145]: #2145 [#2152]: #2152 [#2162]: #2162 [#2213]: #2213 [#2250]: #2250 [#2258]: #2258
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a companion trait to
KeyInit*for exporting a key to a byte array sized according toKeySizeUser.This is needed when generating e.g. asymmetric secret keys types using the
Generatetrait and it returns an actual key type (e.g.SigningKey,DecryptionKey,DecapsulationKey) as opposed to its serialized byte representation.This PR also shows another use case for it: there's currently a gap in the
kemcrate around serialization where you can generically go fromDecapsulate::encapsulatorto the associated encapsulation key for a KEM, but there is currently no generic way to serialize it.It adds
TryKeyInitandKeyExportbounds tokem::Encapsulate, because as the public key component we should always be able to serialize/deserialize it.(NOTE: happy to split the
kemchanges out, that would probably be for the best, but I thought it would help illustrate the use case)