crypto-common: use core::error::Error trait; MSRV 1.81#1660
Conversation
The `core::error::Error` trait is now stable, meaning we no longer need to gate impls for it on a `std` feature.
|
Note: only did |
|
Also, perhaps we should consider removing the Right now std = ["getrandom?/std", "rand_core?/std"]I didn't remove it to keep the change minimal for now, but it's something we could do potentially. I don't think the transitive activation of the |
|
I would really like to migrate to
I agree. |
|
Okay, will leave this as-is and we can take a look again when 1.82 is released (October 17th) |
|
If this is merged, will you make similar changes to crates in other repositories owned by RustCrypto? |
|
Yes, we will apply similar changes (including MSRV bump) to our downstream crates as well. Since RustCrypto/hybrid-array#85 has already landed, we are likely to move forward with this change. |
tarcieri
changed the title
core::error::Error trait; MSRV 1.81core::error::Error trait; MSRV 1.81
|
I removed draft. I'll hold off on merging until I'm ready to update the downstream crates accordingly (busy today / this weekend) |
The MSRVs for dependent crates did not get bumped before #1660 was merged. This bumps them accordingly.
The MSRVs for dependent crates did not get bumped before #1660 was merged. This bumps them accordingly.
The MSRVs for dependent crates did not get bumped before #1660 was merged. This bumps them accordingly.
The MSRVs for dependent crates did not get bumped before #1660 was merged. This bumps them accordingly.
The MSRVs for dependent crates did not get bumped before #1660 was merged. This bumps them accordingly.
The MSRVs for dependent crates did not get bumped before #1660 was merged. This bumps them accordingly.
The MSRVs for dependent crates did not get bumped before #1660 was merged. This bumps them accordingly.
As of #1660, the `crypto-common` crate stopped linking `std` entirely by switching to `core::error::Error`. That PR didn't remove the `std` feature however, which was retained to transitively activate the `std` features of `getrandom` and `rand_core` optioinally in the event their corresponding features are enabled. This PR goes ahead and removes it entirely, which also unblocks being able to remove the `std` feature from other crates like `aead`, `cipher`, `digest`, and `universal-hash`.
As of #1660, the `crypto-common` crate stopped linking `std` entirely by switching to `core::error::Error`. That PR didn't remove the `std` feature however, which was retained to transitively activate the `std` features of `getrandom` and `rand_core` optioinally in the event their corresponding features are enabled. This PR goes ahead and removes it entirely, which also unblocks being able to remove the `std` feature from other crates like `aead`, `cipher`, `digest`, and `universal-hash`.
As of #1660, the `crypto-common` crate stopped linking `std` entirely by switching to `core::error::Error`. That PR didn't remove the `std` feature however, which was retained to transitively activate the `std` features of `getrandom` and `rand_core` optioinally in the event their corresponding features are enabled. This PR goes ahead and removes it entirely, which also unblocks being able to remove the `std` feature from other crates like `aead`, `cipher`, `digest`, and `universal-hash`.
### Added - Sealed `BlockSizes` trait implemented for types from `U1` to `U255` ([#1172]) - `SerializableState` trait under `hazmat` module ([#1369]) - `OutputSize` type alias ([#1533]) - `IvState` trait ([#1636]) - `core::error::Error` impls for error types ([#1660]) - `Generate` trait as a common RNG API ([#2096], [#2145]) - `TryKeyInit` trait ([#2097]) - Re-export `getrandom` ([#2152]) - `KeyExport` trait ([#2213]) ### Changed - Replaced `generic-array` with `hybrid-array` ([#1319], [#1976]) - `BlockUser::BlockSize` is now bounded by the `BlockSizes` trait - Edition changed to 2024 and MSRV bumped to 1.85 ([#1759]) - `generate_*` methods on `KeyInit` and `KeyIvInit` traits have been deprecated in favor of the new `Generate` trait ([#2162]) - Bump `rand_core` to v0.10 ([#2250]) - Bump `getrandom` to v0.4 ([#2258]) ### Removed - `std` feature ([#1680]) [#1172]: #1172 [#1319]: #1319 [#1369]: #1369 [#1533]: #1533 [#1636]: #1636 [#1660]: #1660 [#1680]: #1680 [#1759]: #1759 [#1976]: #1976 [#2096]: #2096 [#2097]: #2097 [#2145]: #2145 [#2152]: #2152 [#2162]: #2162 [#2213]: #2213 [#2250]: #2250 [#2258]: #2258
3 participants
The
core::error::Errortrait is now stable, meaning we no longer need to gate impls for it on astdfeature.