Skip to content

Update bingcd#846

Merged
tarcieri merged 42 commits intoRustCrypto:masterfrom
erik-3milabs:update-gcd
Jul 3, 2025
Merged

Update bingcd#846
tarcieri merged 42 commits intoRustCrypto:masterfrom
erik-3milabs:update-gcd

Conversation

@erik-3milabs
Copy link
Contributor

@erik-3milabs erik-3milabs commented Jun 17, 2025 •
edited
Loading

This PR

  • refactors the bingcd code to better locations in the crate,
  • fixes a bug in bingcd (as shown in 110735a), and
  • support Int::bingcd
  • speeds up the bingcd test suite (as requested in Binary GCD #755)
  • Implement bingcd_vartime

erik-3milabs
erik-3milabs commented Jun 19, 2025
View reviewed changes
@erik-3milabs erik-3milabs mentioned this pull request Jun 20, 2025
Merged
@erik-3milabs
Move bingcd to modular
f8f60c8
@erik-3milabs
Move u32_const_min and u32_const_max
e73d15c
@erik-3milabs
Move modular::bingcd content to uint::bingcd
0f38060
@erik-3milabs
Minor Uint::bingcd performance improvement
0705fcd
@erik-3milabs
Move NonZeroUint::bingcd + minor performance improvement
be3428c
@erik-3milabs
Move OddUint::bingcd
91eb044
@erik-3milabs
Move Odd::<Uint>::BITS
6af113c
@erik-3milabs
Expand bingcd test suite
806a6be
@erik-3milabs
Get update from binxgcd
c91646d
@erik-3milabs
Fix miri compile error
f9851d7
@erik-3milabs
Introduce Int::bingcd
18f17f2
@erik-3milabs
Fix bug in NonZeroUint::bingcd
fece627
@erik-3milabs
Simplify bingcd tests
4efd5a7
@erik-3milabs
Speed up int_bingcd_tests
8db6d3d
@erik-3milabs
Speed up bingcd tests
e1a59e2
@erik-3milabs
Clean up BinxgcdMatrix tests
3be273a
@erik-3milabs
Update Uint::gcd benchmarks
8060367
@erik-3milabs
Limb::conditional_swap
19d02f0
@erik-3milabs
Rename Limb::conditional_swap to ::ct_conditional_swap
0927f39
@erik-3milabs
Speed up Uint::conditional_swap
8afa3dc
@erik-3milabs
Add bingcd proptest
946fcd9
@erik-3milabs
Remove randomized bingcd tests
388ddd9
@erik-3milabs
Speed up matrix::conditional_subtract_bottom_row_from_top
006b4ba
@erik-3milabs
Minor clean up
3162e89
@erik-3milabs
Implement Uint::bounded_overflowing_shr
24ffc41
@erik-3milabs
Use bounded_overflowing_shr to speed up optimized_bingcd
215de1f
@erik-3milabs erik-3milabs marked this pull request as ready for review June 23, 2025 08:06
@erik-3milabs
Copy link
Contributor Author

erik-3milabs commented Jun 23, 2025

@erik-3milabs is this ready for review?

Yup! Forgot to press "review"; wanted to make sure the CI passed before I did.

This was referenced Jun 24, 2025
Merged
Merged
Closed
@erik-3milabs
Copy link
Contributor Author

erik-3milabs commented Jun 24, 2025

@tarcieri this one is ready for review

erik-3milabs
erik-3milabs commented Jun 24, 2025
View reviewed changes
@erik-3milabs erik-3milabs requested a review from tarcieri June 25, 2025 06:41
@erik-3milabs
Copy link
Contributor Author

erik-3milabs commented Jun 30, 2025

@tarcieri do you have a projected timeline on reviewing/merging this and the other three binxgcd PRs?

@tarcieri
Copy link
Member

tarcieri commented Jun 30, 2025

@erik-3milabs I can take a look in the next few days though I’m busy today

@erik-3milabs
Copy link
Contributor Author

erik-3milabs commented Jun 30, 2025

@erik-3milabs I can take a look in the next few days though I’m busy today

Excellent. No rush; just wanted to know what to expect. I'll keep an eye out for any notifications on this thread :)

tarcieri
tarcieri reviewed Jul 2, 2025
View reviewed changes
Cargo.toml
Comment on lines 83 to 85

[profile.dev]
opt-level = 2
Copy link
Member

@tarcieri tarcieri Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably good to leave around, IMO

Copy link
Contributor Author

@erik-3milabs erik-3milabs Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I readded these lines.

@erik-3milabs
Copy link
Contributor Author

erik-3milabs commented Jul 3, 2025

Clippy is failing in Rust v1.88. Posted the fix in #859.

@erik-3milabs erik-3milabs mentioned this pull request Jul 3, 2025
Merged
@erik-3milabs
Copy link
Contributor Author

erik-3milabs commented Jul 3, 2025

@tarcieri fixed the CI & the two points you mentioned. Let me know if there is anything else I can do to have this PR merged.

@tarcieri tarcieri merged commit 5222e72 into RustCrypto:master Jul 3, 2025
23 checks passed
@dmitris dmitris mentioned this pull request Sep 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarcieri tarcieri tarcieri approved these changes

+2 more reviewers

@dolevmu dolevmu dolevmu approved these changes

@ofirfriedman42 ofirfriedman42 ofirfriedman42 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erik-3milabs @tarcieri @dolevmu @ofirfriedman42