Merged
Conversation
Member
Author
tarcieri
force-pushed
the
add-ignore-attr-to-bingcd-tests
branch
from
4cbef29 to
e7e15d1
Compare
In their current form these tests take quite awhile to execute. Adding `#[ignore]` omits them from typical test runs so the test suite still executes quickly. The main `test` job in CI has been configured to run them with `--ignored`.
tarcieri
force-pushed
the
add-ignore-attr-to-bingcd-tests
branch
from
e7e15d1 to
6ed6290
Compare
tarcieri
commented
Jun 19, 2025
| } | ||
|
|
||
| #[test] | ||
| #[ignore] // TODO(tarcieri): improve performance |
Member
Author
There was a problem hiding this comment.
@erik-3milabs I can list you on these if you prefer (or we can open a tracking issue and put the issue number)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In their current form these tests take quite awhile to execute.
Adding
#[ignore]omits them from typical test runs so the test suite still executes quickly.The main
testjob in CI has been configured to run them with--ignored.