Conversation
Closed
59bf09a to
34553de
Compare
Member
|
FYI, I just merged Tiger in #229, so you'll probably want to rebase |
2 tasks
6 tasks
tarcieri
reviewed
Feb 9, 2021
tarcieri
reviewed
Feb 9, 2021
|
Our bitcoin lib need to be compiled in Wasm, 0.9.0 can't work now... I try 0.10 is ok, hoping this pr could be merged soon... |
Member
Author
|
0.9 versions should work fine on WASM. If it's a problem with our crates, can you please open an issue with a description and reproduction steps? |
16fd1b6 to
1f75d09
Compare
This was referenced Nov 17, 2021
faa4ba1 to
29038d3
Compare
d89101d to
bcf9698
Compare
This was referenced Nov 23, 2021
Closed
4e2abaf to
4deb284
Compare
Member
Author
|
BTW I wonder if we should synchronize all hasher crate versions to v0.10. It would make it much easier to see at a single glance which trait version a crate implements, but it would mean we will have a discontinuity in minor versions for some crates, e.g. |
39e587d to
37e29b1
Compare
This was referenced Dec 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on RustCrypto/traits#819.
Notable changes:
ripemd160,ripemd256, andripemd320merged intoripemd.groestlcrate using (public domain) code from the NIST submission as a reference. Now the crate has an acceptable performance (~100 MB/s vs ~1 MB/s). It can be improved even further by utilizing AES-NI and SIMD in general, but I don't plan to work on it myself.fsbimprovements.sha2,streebog, andshabalare implemented in terms of theVariableOutputCoretrait. For example,Sha512VarCoreimplements it, but supports initialization only for 4 sizes and its variants are defined as:Closes #67
Closes #317
Closes #330