add tiger hash from https://gitlab.com/rawler/tiger#229
add tiger hash from https://gitlab.com/rawler/tiger#229tarcieri merged 13 commits intoRustCrypto:masterfrom
Conversation
|
Looks like you need to |
tiger/Cargo.toml
Outdated
| version = "0.1.2" | ||
| description = "Tiger hash function" | ||
| authors = ["Ulrik Mikaelsson <ulrik.mikaelsson@gmail.com>", "RustCrypto Developers"] | ||
| license = "Apache-2.0" |
There was a problem hiding this comment.
All of our other crates are MIT OR Apache-2.0. Is that acceptable?
There was a problem hiding this comment.
that's a good question. The original work is released under Apache 2.0. From reading https://law.stackexchange.com/questions/6081/can-i-bundle-mit-licensed-components-in-a-apache-2-0-licensed-project it seems like adding this under the MIT license is easy?
Should we ask Ulirk?
There was a problem hiding this comment.
It would definitely be good to get the original author's blessing to republish it as MIT+Apache2.0
There was a problem hiding this comment.
I have emailed him. I started to make it look like it was under both licenses, but removed that.
|
based on the failure on thumbv7em-none-eabi the byte-order crate doesn't work under nostd. Looks like what it does you can use byte-tools instead. I'll work on that. |
|
The license issue is pretty important as we try to ensure our crates all have consistent licensing and a clear IPR story. We can wait to hear from the author or you can revive #50. Perhaps you can benchmark the two and see if there's a compelling reason other than licensing to go with one over the other? |
I will make the changes to have it listed as under MIT OR Apache 2.0 |
|
benchmark of this PR's tiger crate: |
|
I have spent 20 minutes to try to get #50 to compile and pass tests so that I can benchmark, but it's failing tests. I propose this PR is ready for merging. |
|
Looks good, thank you! I'll cut a 0.1 after merging. |
|
It's released: https://crates.io/crates/tiger |
Add the tiger hash.
The bulk of this is from Ulrik Mikaelsson but also work from Igor Raits and myself in upgrading to newer versions of the Digest crate.
@tarcieri suggested adding this crate to this repo so that it can be updated as needed.