ecdsa: bump rand_core from 0.6.4 to 0.9.0#901
Closed
baloo wants to merge 1 commit intoRustCrypto:masterfrom
Closed
ecdsa: bump rand_core from 0.6.4 to 0.9.0#901baloo wants to merge 1 commit intoRustCrypto:masterfrom
baloo wants to merge 1 commit intoRustCrypto:masterfrom
Conversation
baloo
force-pushed
the
baloo/ecdsa/bump-rand-core
branch
from
508b358 to
6a07484
Compare
tarcieri
pushed a commit
to RustCrypto/traits
that referenced
this pull request
Feb 15, 2025
This is so that a `RandomizedDigestSigner` can call into `hazmat::RandomizedPrehashSigner` directly with the provided rng. Example use: RustCrypto/signatures#901
baloo
force-pushed
the
baloo/ecdsa/bump-rand-core
branch
from
c3f377d to
0633ed0
Compare
baloo
commented
Feb 16, 2025
| let z = bits2field::<C>(prehash)?; | ||
| let mut ad = FieldBytes::<C>::default(); | ||
| rng.fill_bytes(&mut ad); | ||
| rng.try_fill_bytes(&mut ad).map_err(|_| Error::new())?; |
Member
Author
There was a problem hiding this comment.
Same situation here, we're eating the error from the Rng
This was referenced Feb 16, 2025
baloo
force-pushed
the
baloo/ecdsa/bump-rand-core
branch
3 times, most recently
from
6f10d63 to
2efd584
Compare
baloo
force-pushed
the
baloo/ecdsa/bump-rand-core
branch
from
2efd584 to
032c465
Compare
Member
Author
|
closed in favor of #913 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on:
TryCryptoRngtraits#1752