Update signing method signatures to match upstream traits#907
Update signing method signatures to match upstream traits#907nresare wants to merge 1 commit intoRustCrypto:masterfrom
Conversation
The method signatures in RandomizedPrehashSigner and RandomizedDigestSigner have updated in the signature crate. This change makes the relevant changes to have the implementations match the updated traits
|
This PR contains the changes I had to make to be able to build against the unreleased changes that have recently been merged to HEAD in the https://github.com/RustCrypto/traits repo. When a new pre-release of the signature create is released I expect to update this change and have build with released artefacts. I went with using try_fill_bytes().expect() as this reflects the old behaviour (panic on failure to read random data). One could possibly argue that it should be possible to modify the returned Result such that we can recover from this failure, but I think that in practice failure to obtain random data should be a terminal error. This might be of interest to @baloo, and hopefully I haven't duplicated too much effort |
|
If you're consuming those pre-release crates, you should be able to just pin versions. Bumping the ecosystem to This otherwise duplicates work done in #901, but that can't merge before RustCrypto/traits#1751 gets merged (and probably RustCrypto/traits#1755). Once this is done, we will need to bump the downstream crates of |
|
Oh, I feel a bit silly now, completely missed #901 and it turns out it is indeed duplicated effort. I'm not consuming pre-release crates, but rather looking at some unrelated experimentation that required changes in tandem to crates If you would like any help propagating the rand version bump into all the nooks and crannies of the code base once the core parts have landed, I'm happy to help. Closing this now, as as it duplicates #901 |
For now, I think the "core" should be mostly done (except dsa, which we need to bump to crypto-bigint first (#906)). In any case, help is always appreciated ;) |
The method signatures in RandomizedPrehashSigner and RandomizedDigestSigner have updated in the signature crate. This change makes the relevant changes to have the implementations match the updated traits