Merged
Conversation
The previous implementation used separate `#[target_feature(...)]` blocks for each `core::arch` intrinsic. This thwarts the inliner, so these all translated to `call` instructions. This change inlines the intrinsic calls into larger `#[target_feature(...)]`-gated functions. When compiling with `-C target-cpu=skylake`, the generated assembly matches the idealized version as described in this QuarksLab blog post: https://blog.quarkslab.com/reversing-a-finite-field-multiplication-optimization.html
Merged
This was referenced Jul 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation used separate
#[target_feature(...)]blocks for eachcore::archintrinsic. This thwarts the inliner, so these all translated tocallinstructions.This change inlines the intrinsic calls into larger
#[target_feature(...)]-gated functions.When compiling with
-C target-cpu=skylake, the generated assembly matches the idealized version (for at least the Montgomery fast reduction) as described in this QuarksLab blog post:https://blog.quarkslab.com/reversing-a-finite-field-multiplication-optimization.html
Their version:
Godbolt: https://godbolt.org/z/Zjuvwu