Skip to content

block-padding: remove PadType and add pad_detached method#1225

Merged
newpavlov merged 11 commits intomasterfrom
block-padding/rm_pad_type
Sep 26, 2025
Merged

block-padding: remove PadType and add pad_detached method#1225
newpavlov merged 11 commits intomasterfrom
block-padding/rm_pad_type

Conversation

@newpavlov
Copy link
Member

@newpavlov newpavlov commented Sep 23, 2025

PadType is used only in the default implementation of unpad_blocks and in inout. To handle the latter case Padding::pad_detached is added.

@newpavlov
Copy link
Member Author

PadType is used in inout, I will look into whether it's necessary.

@newpavlov newpavlov changed the title block-padding: remove PadType block-padding: remove PadType and add pad_detached method Sep 26, 2025
@newpavlov newpavlov merged commit 1b849b1 into master Sep 26, 2025
100 checks passed
@newpavlov newpavlov deleted the block-padding/rm_pad_type branch September 26, 2025 07:44
newpavlov added a commit that referenced this pull request Oct 6, 2025
### Added
- `Padding::pad_detached` method ([#1225])

### Changed
- Migrated from `generic-array` to `hybrid-array` ([#944])
- Edition changed to 2024 and MSRV bumped to 1.85 ([#1149])
- Merged `RawPadding` and `Padding` traits ([#1217])
- Renamed `UnpadError` to `Error` ([#1225])

### Removed
- `Block` type alias ([#1217])
- `PadType` enum and associated type on the `Padding` trait ([#1225])

[#944]: #944
[#1149]: #1149
[#1217]: #1217
[#1225]: #1225
newpavlov added a commit that referenced this pull request Oct 6, 2025
…1227)

In #1225 I forgot to overwrite the default implementation of
`pad_detached` for `NoPadding` and `ZeroPadding`.

Additionally, this PR adds `PaddedData` enum to make return type of
`pad_detached` less complex.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants