block-padding: fix pad_detached for NoPadding and ZeroPadding#1227
Merged
block-padding: fix pad_detached for NoPadding and ZeroPadding#1227
pad_detached for NoPadding and ZeroPadding#1227Conversation
newpavlov
changed the title
pad_detached, add PaddedData enumpad_detached for NoPadding and ZeroPadding, add PaddedData enum
newpavlov
changed the title
pad_detached for NoPadding and ZeroPadding, add PaddedData enumpad_detached for NoPadding and ZeroPadding
Member
Author
|
Damn, I thought I merged this PR earlier. I guess I will yank v0.4.0 and will release v0.4.1 with this fix. |
tarcieri
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1225 I forgot to overwrite the default implementation of
pad_detachedforNoPaddingandZeroPadding.Additionally, this PR adds
PaddedDataenum to make return type ofpad_detachedless complex.