Skip to content

Removed flash filter from Stage1 standard configuration [SBN2023A] #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mmrosenberg merged 4 commits into from
May 24, 2023
Merged

Removed flash filter from Stage1 standard configuration [SBN2023A] #578

mmrosenberg merged 4 commits into from
May 24, 2023

Conversation

@PetrilloAtWork
Copy link
Member

@PetrilloAtWork PetrilloAtWork commented May 5, 2023

Twin pull request of #577 but for the production branch. Discussion goes there.

@mmrosenberg
Copy link
Contributor

mmrosenberg commented May 5, 2023

trigger build LArSoft/lar*@LARSOFT_SUITE_v09_72_00 SBNSoftware/sbncode@v09_72_00_03 SBNSoftware/sbnanaobj@v09_20_06 SBNSoftware/sbndaq_artdaq_core@v1_06_00of0 SBNSoftware/sbnobj@v09_16_00 SBNSoftware/icarus_signal_processing@v09_63_00_02 SBNSoftware/icarusalg@v09_72_00 SBNSoftware/icarusutil@v09_66_02

@FNALbuild
Copy link
Collaborator

FNALbuild commented May 6, 2023

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented May 6, 2023

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented May 6, 2023

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented May 6, 2023

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@mmrosenberg
Copy link
Contributor

mmrosenberg commented May 8, 2023

trigger build LArSoft/lar*@LARSOFT_SUITE_v09_72_00 SBNSoftware/sbncode@v09_72_00_03 SBNSoftware/sbnanaobj@v09_20_06 SBNSoftware/sbndaq-artdaq-core@v1_06_00of0 SBNSoftware/sbnobj@v09_16_00 SBNSoftware/icarus_signal_processing@v09_63_00_02 SBNSoftware/icarusalg@v09_72_00 SBNSoftware/icarusutil@v09_66_02

@FNALbuild
Copy link
Collaborator

FNALbuild commented May 8, 2023

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented May 8, 2023

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented May 9, 2023

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented May 9, 2023

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

SFBayLaser
SFBayLaser approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@SFBayLaser SFBayLaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate. I commented in the other one... (PR #577)

@PetrilloAtWork PetrilloAtWork mentioned this pull request May 10, 2023
Merged
@PetrilloAtWork
Copy link
Member Author

PetrilloAtWork commented May 10, 2023 •
edited
Loading

PR #577 implemented a request to remove nofilter configurations since they are completely equivalent to the mainline ones. One of them, stage1_run2_nofilter_icarus.fcl, is part of the official production chain and it would be superseded by stage1_run2_icarus.fcl (which is already present in this PR).
The question for the production group (@mattfcs?) is if it's ok for this change to happen.

@PetrilloAtWork PetrilloAtWork requested review from mattfcs and removed request for mattfcs May 10, 2023 04:50
@PetrilloAtWork
Removed 'nofilter' configurations
cb3f9ce 
They are equivalent to the mainline configurations, by which they are now replaced.
@PetrilloAtWork
Fixed configuration using a renamed one.
73b3626
@PetrilloAtWork
Copy link
Member Author

PetrilloAtWork commented May 23, 2023

Applied the two additional commits like in the development branch (PR #577).
Production will need to update the Stage1 job configuration file name from stage1_run2_nofilter_icarus.fcl to stage1_run2_icarus.fcl.

@mmrosenberg
Copy link
Contributor

mmrosenberg commented May 23, 2023

trigger build LArSoft/lar*@LARSOFT_SUITE_v09_72_00 SBNSoftware/sbncode@v09_72_00_03 SBNSoftware/sbnanaobj@v09_20_06 SBNSoftware/sbndaq-artdaq-core@v1_06_00of0 SBNSoftware/sbnobj@v09_16_00 SBNSoftware/icarus_signal_processing@v09_63_00_02 SBNSoftware/icarusalg@v09_72_00 SBNSoftware/icarusutil@v09_66_02

@FNALbuild
Copy link
Collaborator

FNALbuild commented May 23, 2023

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented May 23, 2023

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented May 23, 2023

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented May 23, 2023

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@mmrosenberg mmrosenberg merged commit 9fbc84b into SBNSoftware:release/SBN2023A May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SFBayLaser SFBayLaser SFBayLaser approved these changes

@mmrosenberg mmrosenberg mmrosenberg approved these changes

@mattfcs mattfcs Awaiting requested review from mattfcs

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@PetrilloAtWork @mmrosenberg @FNALbuild @SFBayLaser