Skip to content

Removed flash filter from Stage1 standard configuration [SBN2023A] #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmrosenberg merged 4 commits into from
May 24, 2023
Merged

Removed flash filter from Stage1 standard configuration [SBN2023A] #578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f1eb129
Removed flash filter from Stage1 standard configuration.
PetrilloAtWork May 4, 2023
eb596f5
Updated list of FHiCL to be skipped by unit test
PetrilloAtWork May 4, 2023
cb3f9ce
Removed 'nofilter' configurations
PetrilloAtWork May 10, 2023
73b3626
Fixed configuration using a renamed one.
PetrilloAtWork May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions fcl/SkipTesting.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ set_caf_calconst.fcl
# This should at least allow the issues not to grow.
#

job/OnlineDecoder.fcl
job/bnbanaicarus21apr21.fcl
job/dirtanaicarus21apr21.fcl
job/icarus_ci_nucosmics_anatree_quick_test_icaruscode.fcl
Expand All @@ -55,13 +54,9 @@ job/prodcosmics_corsika_proton_21apr21_ob.fcl
job/prodgenie_nu_spill_indirt.fcl
job/prodsingle_full_optical_electronic.fcl
job/prodsingle_optical_electronic.fcl
job/run_flashfilter_data.fcl
job/run_icarus_flashfinder.fcl
job/run_opreco.fcl
job/run_opreco_data.fcl
job/stage0_EastCryo_icarus.fcl
job/stage0_multiTPC_splitstream_east_icarus.fcl
job/stage0_multiTPC_splitstream_west_icarus.fcl
job/standard_g4_icarus_21apr21_noob.fcl
job/standard_g4_icarus_21apr21_ob.fcl
job/study_ophit_singlep.fcl
Expand All @@ -72,7 +67,6 @@ job/study_ophit_singlep_290.fcl
job/study_ophit_singlep_310.fcl
job/study_ophit_singlep_330.fcl
job/study_ophit_singlep_350.fcl
job/testDecoderFilter.fcl
job/var_10pe_5hits_1us_020ns.fcl
job/var_20pe_5hits_1us_020ns.fcl
job/var_30pe_5hits_1us_020ns.fcl
Expand Down
6 changes: 1 addition & 5 deletions fcl/reco/Definitions/stage0_icarus_defs.fcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,7 @@ icarus_stage0_filters:
#
flashfilterBNB: { module_type: "FilterOpFlash"
OpFlashProducerList: ["opflashCryoE","opflashCryoW"]
# WindowStartTime: -1489.6 # -1489.4 - 0.2us safe margin
# WindowEndTime: -1487.6 # -1487.8 + 0.2us safe margin
# WindowStartTime: -1490.8 # 9.6 us - 1500 us offset - 0.4us safe margin
# WindowEndTime: -1488.4 # 11.2 -1500 us offset + 0.4us safe margin
WindowStartTime: -0.2 # Gate is now recentered by Gianluca/Andrea
WindowStartTime: -0.2 # 0.2us safe margin
WindowEndTime: 1.8
}
flashfilterNuMI: { module_type: "FilterOpFlash"
Expand Down
6 changes: 1 addition & 5 deletions fcl/reco/Definitions/stage0_icarus_defs_run1.fcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,7 @@ icarus_stage0_filters:
#
flashfilterBNB: { module_type: "FilterOpFlash"
OpFlashProducerList: ["opflashCryoE","opflashCryoW"]
# WindowStartTime: -1489.6 # -1489.4 - 0.2us safe margin
# WindowEndTime: -1487.6 # -1487.8 + 0.2us safe margin
# WindowStartTime: -1490.8 # 9.6 us - 1500 us offset - 0.4us safe margin
# WindowEndTime: -1488.4 # 11.2 -1500 us offset + 0.4us safe margin
WindowStartTime: -0.2 # Gate is now recentered by Gianluca/Andrea
WindowStartTime: -0.2 # 0.2us safe margin
WindowEndTime: 1.8
}
flashfilterNuMI: { module_type: "FilterOpFlash"
Expand Down
8 changes: 0 additions & 8 deletions fcl/reco/Definitions/stage1_icarus_defs.fcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,14 +69,6 @@ icarus_stage1_producers:

icarus_stage1_filters:
{
flashfilter: { module_type: "FilterOpFlash"
OpFlashProducerList: ["opflashCryoW","opflashCryoE"]
# WindowStartTime: -1489.6 # -1489.4 - 0.2us safe margin
# WindowEndTime: -1487.6 # -1487.8 + 0.2us safe margin
WindowStartTime: -1490.8 # 9.6 us - 1500 us offset - 0.4us safe margin
WindowEndTime: -1488.4 # 11.2 -1500 us offset + 0.4us safe margin
}

TPCHitFilterCryoW: @local::icarus_FilterNumberTPCHits
TPCHitFilterCryoE: @local::icarus_FilterNumberTPCHits
}
Expand Down
3 changes: 1 addition & 2 deletions fcl/reco/Stage1/Run1/stage1_multiTPC_icarus_gauss.fcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@

process_name: stage1

physics.reco: [ flashfilter,
@sequence::icarus_filter_cluster3D,
physics.reco: [ @sequence::icarus_filter_cluster3D,
@sequence::icarus_pandora_Gauss,
@sequence::icarus_reco_fm,
@sequence::icarus_crttrack,
Expand Down
52 changes: 0 additions & 52 deletions fcl/reco/Stage1/Run1/stage1_multiTPC_nofilter_icarus_gauss.fcl
View file
Open in desktop

This file was deleted.

0 ...tage1_singleTPC_nofilter_icarus_gauss.fcl → ...e1/Run1/stage1_singleTPC_icarus_gauss.fcl
View file
Open in desktop
File renamed without changes.
3 changes: 1 addition & 2 deletions fcl/reco/Stage1/Run2/stage1_run2_icarus.fcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@

process_name: stage1

physics.reco: [ flashfilter,
@sequence::icarus_filter_cluster3D,
physics.reco: [ @sequence::icarus_filter_cluster3D,
@sequence::icarus_pandora_Gauss,
@sequence::icarus_reco_fm,
@sequence::icarus_crttrack,
Expand Down
69 changes: 0 additions & 69 deletions fcl/reco/Stage1/Run2/stage1_run2_nofilter_icarus.fcl
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion .../stage1_runA_nofilter_icarus_nosupera.fcl → ...age1/RunA/stage1_runA_icarus_nosupera.fcl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include "stage1_run2_nofilter_icarus.fcl"
#include "stage1_run2_icarus.fcl"

# don't run supera -- crashes on old files
physics.outana: [
Expand Down
20 changes: 5 additions & 15 deletions icaruscode/Filters/run_flashfilter_data.fcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,7 @@

process_name: OpReco

services:
{
@table::icarus_basic_services
}

source:
{
module_type: RootInput
}
services: @local::icarus_minimum_services # from services_common_icarus.fcl

physics:
{
Expand All @@ -22,8 +14,8 @@ physics:
{
ophit: @local::icarus_ophit_data
ophitfull: @local::icarus_ophitdebugger_data
opflashCryo0: @local::ICARUSSimpleFlashDataCryo0
opflashCryo1: @local::ICARUSSimpleFlashDataCryo1
opflashCryo0: @local::ICARUSSimpleFlashDataCryoE
opflashCryo1: @local::ICARUSSimpleFlashDataCryoW

}
analyzers: {
Expand All @@ -33,10 +25,8 @@ physics:
filters: {
flashfilter: { module_type: "FilterOpFlash"
OpFlashProducerList: ["opflashCryo0","opflashCryo1"]
# WindowStartTime: -1489.6 # -1489.4 - 0.2us safe margin
# WindowEndTime: -1487.6 # -1487.8 + 0.2us safe margin
WindowStartTime: -1490.8 # 9.6 us - 1500 us offset - 0.4us safe margin
WindowEndTime: -1488.4 # 11.2 -1500 us offset + 0.4us safe margin
WindowStartTime: -0.2 # 0.2us safe margin
WindowEndTime: 1.8
}
}

Expand Down