Skip to content

Conversation

@sjgardiner
Copy link
Contributor

Updates the list of GENIE Reweight systematics dials to be compatible with GENIE v3.4.0 with the AR23_20i_00_000 model set

@sjgardiner sjgardiner requested a review from jedori0228 July 25, 2023 18:59
@sjgardiner sjgardiner self-assigned this Jul 25, 2023
(syst_params_icarus_v2.fcl) by running GenerateSystProviderConfig on the
new configuration fcls provided in the previous commit
@sjgardiner sjgardiner force-pushed the feature/gardiner-genie-syst-updates branch from b227daa to 9067c87 Compare July 25, 2023 19:06
@jedori0228
Copy link
Contributor

I wonder if we want to have v1 along with v2, with a directory structure like below...

[/SystTools]$ tree
.
|-- CMakeLists.txt
|-- configs
|   |-- CMakeLists.txt
|   |-- icarus_v1
|   |   |-- CMakeLists.txt
|   |   |-- config_All_icarus_v1.fcl
|   |   |-- config_GENIEReWeightMultisigma_icarus_v1.fcl
|   |   |-- config_GENIEReWeightMultisim_icarus_v1.fcl
|   |   |-- config_MINERvA_E2p2h_icarus_v1.fcl
|   |   |-- config_MINERvAq0q3Tune_icarus_v1.fcl
|   |   |-- config_MiscInteractionSysts_icarus_v1.fcl
|   |   `-- config_NOvAStyleNonResPion_icarus_v1.fcl
|   `-- icarus_v2
|       |-- CMakeLists.txt
|       |-- config_All_icarus_v2.fcl
|       |-- config_GENIEReWeightMultisigma_icarus_v2.fcl
|       |-- config_GENIEReWeightMultisim_icarus_v2.fcl
|       |-- config_MINERvA_E2p2h_icarus_v2.fcl
|       |-- config_MINERvAq0q3Tune_icarus_v2.fcl
|       |-- config_MiscInteractionSysts_icarus_v2.fcl
|       `-- config_NOvAStyleNonResPion_icarus_v2.fcl
|-- eventweight_genie_systtools.fcl
|-- syst_params_icarus_v1.fcl
`-- syst_params_icarus_v2.fcl

@sjgardiner
Copy link
Contributor Author

I guess we could. However, I don't foresee a scenario in which we would want to use the deprecated systematics for anything. They're not really compatible with any of the samples we will use going forward.

@jedori0228
Copy link
Contributor

Five GSysts (RPA_CCQE, CoulombCCQE, ThetaDelta2NRad, NormCCCOH and NormNCCOH) were not recognized by nusystematics, so are missing from icaruscode/fcl/caf/SystTools/syst_params_icarus_v2.fcl. This is fixed in LArSoft/nusystematics#4, and we have to rerun GenerateSystProviderConfig after this is merged.

@mmrosenberg
Copy link
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v09_78_00

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@etworcester
Copy link

Where are we on this and the related SBNCode PR? It would be awesome to update sensitivities for the collaboration meeting coming up. But even if we can't get it done in time for that, it's important to try to move forward with this. Lmk if there's anything I can do to help unstick it

…ent dials properly. Also commenting out FSI CEx dials so that they can be treated as cushions.
@jedori0228
Copy link
Contributor

@etworcester I made a PR to @sjgardiner 's repo (sjgardiner#1), so once it's merged, this PR will be also updated with that.

@mmrosenberg
Copy link
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v09_79_00 SBNSoftware/sbncode@v09_79_00 SBNSoftware/sbnanaobj@v09_21_05 SBNSoftware/sbndaq-artdaq-core@v1_08_00of1 SBNSoftware/sbnobj@v09_17_09

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e26:prof - ignored failure for unit_test -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for c14:prof - ignored failure for unit_test -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants