Configurations For NuMI Analysis #640
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The algorithm creating readout buffers (future `raw::OpDetWaveform`) from the continuous readout was written expecting (and asserting) that a trigger primitive can't be at the first tick of the enable gate. This was a reasonable assumption when the trigger algorithm looked for a transition from the previous tick from below to above threshold. Now an alternative algorithm is also available which considers just the value of the sample compared to the threshold, so that expectation is violated and the assertion failed. A small change in the algorithm makes it robust to that rare occurrence.
Fix a bug in PMT digitization
…rable by fcl. Add in config for 'fit' field responses.
Configuration of that ilter throughout the repository has been fixed.
…r 2D drift." This reverts commit bc9bb19090bb9e96735dff2ac43610d42cdd366e.
They are equivalent to the mainline configurations, by which they are now replaced.
Tuned Simulated Field Responses
GENIE Generation with RHC NuMI Flux
Add in Standalone Calibration NTuple Configs
…N2023A Removed flash filter from Stage1 standard configuration [`SBN2023A`]
…atch Fix truth-match labels in Calibration NTuple-r for 2D drift sim.
…h now ported to the production branch
…he 3D hit building
…roduction Copy of PR #590 and PR 591 for production branch
Note: job fcls are not modified in this commit.
…s, G4 systematics, and detsim detector variations
Contributor
|
The GENIE+G4 updates have now already been included in #612. This PR was originally for the production branch, which uses an older version of LArSoft that does not have the required updates to larreco. Many updates are required to make the remaining updates in this PR compatible with develop, and it was decided to leave that to the authors of the individual changes rather than attempting to fix everything here. So I am closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many updates which implement changes required for the NuMI analysis.
Depends on LArSoft/larreco#59 and SBNSoftware/sbncode#391,
Supersedes #613.