Configurations Enabling ICARUS NuMI Analysis #391

gputnam · 2023-10-22T01:52:58Z

Gathers together a number of updates:

Includes update to GENIE Systematics (from Jaesung)
Includes build of Geant4Systematics
Fix to MeVPrtl
Updates to CAFMaker -- save hits from cathode crossers
Updates to beam spill accounting (from Joseph+Jacob L)
Updates to MCS (from Moon)

Marking as a draft, for now.

…rror if they are

Co-authored-by: Gianluca Petrillo <petrillo@slac.stanford.edu>

…ader

SBNEventWeight differences. Also make some adjustments to get it to build against geant4reweight v01_00_03e -q e20:s117:prof

* Placeholder for sampled parameter storage, for CAF compatibility. * Renamed fcl for consistency

…calorimetry variables

…eam in each run.

…e/gputnam-configs

… feature/gputnam-configs

…m-configs

jzennamo · 2024-01-17T17:22:18Z

@gputnam it might help to base your branch off of my branch here:
#394

this has many similar changes as your PR

jzennamo

Looks good, I might base your PR off my other PR

jzennamo · 2024-01-17T17:27:06Z

sbncode/BeamSpillInfoRetriever/BNBEXTRetriever/BNBEXTRetriever_module.cc

This change is probably best left for this PR:
#394

jzennamo · 2024-01-17T17:27:20Z

sbncode/BeamSpillInfoRetriever/BNBEXTRetriever/CMakeLists.txt

This change is probably best left for this PR:
#394

jzennamo · 2024-01-17T17:27:31Z

sbncode/BeamSpillInfoRetriever/BNBRetriever/BNBRetriever_module.cc

This change is probably best left for this PR:
#394

jzennamo · 2024-01-17T17:27:39Z

sbncode/BeamSpillInfoRetriever/CMakeLists.txt

This change is probably best left for this PR:
#394

jzennamo · 2024-01-17T17:38:51Z

sbncode/BeamSpillInfoRetriever/NuMIEXTRetriever/NuMIEXTRetriever_module.cc

This looks good, I might add a portion which corrects for the minbias gates directly to this accounting, something like this:

if(evtCount != 0 && totalMinBias != 0) scale_factor = 1. - (evtCount/totalMinBias);

from https://github.com/SBNSoftware/sbncode/pull/394/files

jzennamo · 2024-01-17T18:46:21Z

sbncode/SBNEventWeight/Calculators/Geant4/Geant4WeightCalc.cxx

+        //Get the weight from the G4ReweightTraj
+        w = theReweighter->GetWeight( &theTraj );
+        // Total weight is the product of track weights in the event
+        weight[j] *= std::max((float)0.0, w);


should this be the max between 1 and w?

jzennamo · 2024-01-17T18:46:37Z

sbncode/SBNEventWeight/Calculators/Geant4/Geant4WeightCalc.cxx

+
+        // Do the same for elastic weight (should be 1 unless set to non-nominal )
+        el_w = theReweighter->GetElasticWeight( &theTraj );
+        weight[j] *= std::max((float)0.0,el_w);


should this be the max between 1 and w?

jzennamo · 2024-01-17T18:56:58Z

sbncode/SBNEventWeight/jobs/geant4/eventweight_geant4_sbn.fcl

Only comment is that maybe the random seeds should be a bit more....random ;)

jzennamo · 2024-01-17T18:58:01Z

sbncode/SBNEventWeight/jobs/geant4/piplus_reweight_parameters.fcl

+    Name:       "fPiPlusReacLow"
+    Cut:        "reac"
+    Range:      [10., 200.]
+    Nominal:    1


Suggested change

Nominal: 1

Nominal: 1.0

jzennamo · 2024-01-17T18:58:18Z

sbncode/SBNEventWeight/jobs/geant4/proton_reweight_parameters.fcl

+    Name:       "fProtonReac"
+    Cut:        "reac"
+    Range:      [10., 2005.]
+    Nominal:    1


Suggested change

Nominal: 1

Nominal: 1.0

gputnam · 2024-02-05T22:26:15Z

This PR has now been superseded by a combination of other PRs, most recently: #417, https://github.com/SBNSoftware/sbncode/pull/418/files, and #419. Closing this in favor of those.

jedori0228 and others added 28 commits June 2, 2023 12:25

Update SystToolsEventWeight for dependent dials

706c4d8

Duplicated declaration of fParameterSet removed

f0c3c49

Updated to TriggerV3

1407062

Updated to Trigger V3

f24eba3

Update CAFMaker to save offbeam gate count

515724c

Update Params to match Joseph's PR

c0f90b5

Check whether both numi/bnb and offbeam/onbeam are filled and print e…

0af7a05

…rror if they are

Update logger for SystToolsEventWeight_module.cc

12aa749

make check for multiple spill products more robust

0651c08

Co-authored-by: Gianluca Petrillo <petrillo@slac.stanford.edu>

Update SystToolsEventWeight module to treat isCorrection=true paramhe…

58c6946

…ader

Add the MicroBooNE weight calculator that interfaces with geant4reweight

73c8201

Some tweaks to adjust for larsim EventWeight (used by uB) vs.

2bf4884

SBNEventWeight differences. Also make some adjustments to get it to build against geant4reweight v01_00_03e -q e20:s117:prof

geant4reweight interface updates + generic sbn fcls

444f8c1

g4reweight bugfix and temporary parameter storage

192a028

* Placeholder for sampled parameter storage, for CAF compatibility. * Renamed fcl for consistency

Fill true trajectory points.

60b48df

Disable cross-plane stub merging.

8ccae1d

For cosmics that are crossing the cathode we added T0 information in …

99d77ce

…calorimetry variables

exclude region feature

1ce518e

restructure, skip out of fv hits

d4af5fe

Allow time shift in trigger to IFBeam timing. Skip first event in str…

3d2e2c8

…eam in each run.

Merge branch 'feature/jskim_SystToolsUpdate_v09_72_00_03' into featur…

cbc6213

…e/gputnam-configs

Merge branch 'gray_g4rwgt' into feature/gputnam-configs

7a40e9e

Merge branch 'feature/Zennnamo_POT_Trigv3_fix_production_branch' into…

e15fa37

… feature/gputnam-configs

Update sbndata

6f09e1b

Update systematics versions.

e2a5cd8

Include Geant4 libraries for buiding

e32adbc

Fix ALP mass suppression.

b03a6e5

Merge branch 'feature/jlarkin_offbeam_gates_prod' into feature/gputna…

abaafef

…m-configs

gputnam changed the title ~~Feature/gputnam configs~~ Configurations Enabling ICARUS NuMI Analysis Oct 22, 2023

gputnam requested a review from jedori0228 October 22, 2023 02:11

gputnam requested review from cfarnese and jzennamo October 22, 2023 02:11

gputnam marked this pull request as draft October 22, 2023 02:12

This was referenced Oct 22, 2023

Update POT Accounting #373

Closed

Configurations For NuMI Analysis SBNSoftware/icaruscode#640

Closed

jzennamo requested changes Jan 17, 2024

View reviewed changes

gputnam closed this Feb 5, 2024

Configurations Enabling ICARUS NuMI Analysis #391

Configurations Enabling ICARUS NuMI Analysis #391

Uh oh!

Conversation

gputnam commented Oct 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jzennamo commented Jan 17, 2024

Uh oh!

jzennamo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gputnam commented Feb 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

gputnam commented Oct 22, 2023 •

edited

Loading