-
Notifications
You must be signed in to change notification settings - Fork 35
Add Geant4Reweight to sbncode #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SBNEventWeight differences. Also make some adjustments to get it to build against geant4reweight v01_00_03e -q e20:s120a:prof
* Placeholder for sampled parameter storage, for CAF compatibility. * Renamed fcl for consistency
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v09_82_02 |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
trigger build |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
This PR looks reasonable, but the build currently fails due to some compilation problems. I'm pretty sure it's because we are trying to link against geant4reweight v01_20_03, which had API changes relative to the older version (v01_00_03) used in the original code from MicroBooNE. The binary tarball I used for testing was v01_00_03e. My suggested short-term solution is to downgrade to v01_00_03 and test again. We could request an official e26:prof build of that version from SciSoft for the production release. Eventually we'll need to update to use the new API. |
|
After consulting the SciSoft team (see https://cdcvs.fnal.gov/redmine/issues/28572), it looks like we will need to "bite the bullet" and refactor the geant4reweight API calls in sbncode in order to use the new interface. Downgrading leads to a build that runs, but doing it in an actual release is tricky (due to geant4reweight ups dependency on the Geant4 version), and there's no guarantee that the weights will actually be correct given the unexpected combination of G4 and G4Reweight versions. I'll reach out to Jake Calcutt to get some guidance on the scope of changes required. |
|
Bumping this - @grayputnam , is it possible to fix the conflicts here please? I'd like to test this PR with the new LArSoft RC v10_21_00rc0 to see if the build issues persist |
No description provided.