Skip to content

Conversation

@gputnam
Copy link
Contributor

@gputnam gputnam commented Feb 5, 2024

No description provided.

sjgardiner and others added 6 commits July 25, 2023 15:54
SBNEventWeight differences. Also make some adjustments to get it to build
against geant4reweight v01_00_03e -q e20:s120a:prof
* Placeholder for sampled parameter storage, for CAF compatibility.
* Renamed fcl for consistency
@miquelnebot
Copy link
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v09_82_02

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@miquelnebot
Copy link
Contributor

trigger build

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@sjgardiner
Copy link
Contributor

This PR looks reasonable, but the build currently fails due to some compilation problems. I'm pretty sure it's because we are trying to link against geant4reweight v01_20_03, which had API changes relative to the older version (v01_00_03) used in the original code from MicroBooNE. The binary tarball I used for testing was v01_00_03e. My suggested short-term solution is to downgrade to v01_00_03 and test again. We could request an official e26:prof build of that version from SciSoft for the production release. Eventually we'll need to update to use the new API.

@sjgardiner
Copy link
Contributor

After consulting the SciSoft team (see https://cdcvs.fnal.gov/redmine/issues/28572), it looks like we will need to "bite the bullet" and refactor the geant4reweight API calls in sbncode in order to use the new interface. Downgrading leads to a build that runs, but doing it in an actual release is tricky (due to geant4reweight ups dependency on the Geant4 version), and there's no guarantee that the weights will actually be correct given the unexpected combination of G4 and G4Reweight versions. I'll reach out to Jake Calcutt to get some guidance on the scope of changes required.

@kjplows kjplows moved this from Needs revisiting to Open pull requests in SBN software development Mar 26, 2025
@kjplows
Copy link
Contributor

kjplows commented Apr 7, 2025

Bumping this - @grayputnam , is it possible to fix the conflicts here please? I'd like to test this PR with the new LArSoft RC v10_21_00rc0 to see if the build issues persist

@kjplows kjplows moved this from Open pull requests to Needs revisiting in SBN software development Aug 9, 2025
@kjplows
Copy link
Contributor

kjplows commented Sep 10, 2025

@gputnam with the merging of #555 I'm going to close this if that's okay with you?

@kjplows kjplows closed this Sep 10, 2025
@github-project-automation github-project-automation bot moved this from Needs revisiting to Done in SBN software development Sep 10, 2025
@kjplows kjplows moved this from Done to 2025 PRs in SBN software development Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 2025 PRs

Development

Successfully merging this pull request may close these issues.

7 participants