Feature/howard for nu mi2023 a from gputnam configs #694
Conversation
and the AR23_20i_00_000 model set
(syst_params_icarus_v2.fcl) by running GenerateSystProviderConfig on the new configuration fcls provided in the previous commit
…ent dials properly. Also commenting out FSI CEx dials so that they can be treated as cushions.
Note: job fcls are not modified in this commit.
…s, G4 systematics, and detsim detector variations
|
File changes under |
…commits) to then be able to merge (hopefully) Jaesung's area
…yst-updates_v09_72_00_06' into feature/howard_forNuMI2023A_from_gputnam-configs
|
Merged Jaesung's feature branch into this -- this will facilitate testing and makes it slightly easier/fewer things. |
This reverts commit 7753d36.
|
I believe this should now have the geant4weight stuff removed. I pushed another branch |
|
Assigning a reviewer. Sorry Gianluca! 😬 😬 |
PetrilloAtWork
left a comment
PetrilloAtWork
left a comment
There was a problem hiding this comment.
I have left comments on the parts where my own expertise is not naught, but I can't review the systematics variations.
Somebody else should (@jzettle? @jedori0228?).
In general, there is some thing that DB people should cross check, and I would like references to be added to the numbers in the configurations.
| # Recombination fixed, muon+proton fit | ||
| CalConstants: [80.32, 79.82, 82.24, 81.68] | ||
| # Relative normalization of the TPCs | ||
| CalConstants: [1.0118, 1.0000, 1.0333, 1.0230] |
There was a problem hiding this comment.
Magic numbers! reference?
| icarus_simwire_wirecell_fitSR.wcls_main.structs.gain0: 11.9918701 # mV/fC | ||
| icarus_simwire_wirecell_fitSR.wcls_main.structs.gain1: 12.6181926 # mV/fC |
| icarus_data_calconst: [1., 1., 1.] | ||
| # Gain with angular dep. recombination | ||
| # Assume equal on planes -- this is __wrong__ -- will need to be fixed when they are calibrated | ||
| icarus_data_calconst: [0.013316, 0.013316, 0.013316] |
| icarus_calonormtools: [@local::driftnorm, @local::yznorm, @local::tpcgain] | ||
| # icarus_calonormtools: [@local::driftnorm_sql, @local::yznorm_sql, @local::tpcgain_sql] |
There was a problem hiding this comment.
Maybe @jedori0228 or @SFBayLaser can comment on this change? I suppose it is either very right or very wrong, but I never remember which one.
| const recob::Hit &hit, const geo::Point_t &location, const geo::Vector_t &direction, double t0) { | ||
| // Get the info | ||
| ScaleInfo i = GetScaleInfo(e.time().timeHigh()); | ||
| ScaleInfo i = GetScaleInfo(e.id().runID().run()); |
There was a problem hiding this comment.
Skip the middle men!
| ScaleInfo i = GetScaleInfo(e.id().runID().run()); | |
| ScaleInfo i = GetScaleInfo(e.run()); |
| fScaleInfos[run] = thisscale; | ||
| return fScaleInfos.at(run); |
There was a problem hiding this comment.
Or:
| fScaleInfos[run] = thisscale; | |
| return fScaleInfos.at(run); | |
| return fScaleInfos[run] = thisscale; |
(but it may confuse people)
| fScaleInfos[run] = thisscale; | ||
| return fScaleInfos.at(run); |
There was a problem hiding this comment.
As above:
| fScaleInfos[run] = thisscale; | |
| return fScaleInfos.at(run); | |
| return fScaleInfos[run] = thisscale; |
|
trigger build |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
Cherry-picking in what I think are the relevant commits from Gray's feature branch used in the reprocessing.
A few minor edits where necessary to resolve a cherry-pick conflict may be present.
Actually I notice a few things here that relate to GENIE systematics, e.g. config_GENIEReWeightMultisigma_icarus_v2.fcl -- tagging @jedori0228 in case that is already in a commit he has on our board or this or others aren't needed or etc.