Skip to content

Conversation

@brucehoward-physics
Copy link
Contributor

Picking up a few more things Gray pointed out beyond what's in #694 . This should go in after that, as this picks up those commits and adds this.

@SFBayLaser SFBayLaser added the enhancement New feature or request label Feb 29, 2024
@brucehoward-physics brucehoward-physics changed the base branch from release/SBN2023A_NuMI to feature/howard_forNuMI2023A_from_gputnam-configs_CherrypickPR699 March 22, 2024 16:22
@brucehoward-physics brucehoward-physics changed the base branch from feature/howard_forNuMI2023A_from_gputnam-configs_CherrypickPR699 to feature/howard_forNuMI2023A_from_gputnam-configs March 22, 2024 16:22
Copy link
Contributor

@SFBayLaser SFBayLaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will leave my standard lament that variations require separate fhicl files which only serve to make things more challenging to understand. Sigh... well, that shipped sailed many years ago I suppose.

Copy link

@mrmooney mrmooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine to me

@miquelnebot miquelnebot changed the base branch from feature/howard_forNuMI2023A_from_gputnam-configs to release/SBN2023A_NuMI May 30, 2024 20:02
@miquelnebot
Copy link
Contributor

trigger build

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e20:prof - ignored failure for unit_test -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@miquelnebot miquelnebot merged commit 5e41e0a into release/SBN2023A_NuMI May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants