Skip to content

Conversation

@mvicenzi
Copy link
Member

@mvicenzi mvicenzi commented Oct 8, 2024

Last minute fixes for runtime bugs coming from new code of #751 .
Thanks to @aheggest for spotting them!

  • Added missing dictionary definitions for the new PMTBeamSignal structure.
  • Disabled waveform ouput tree from ICARUSFlashAssAna in stage1 (no optical waveforms available).
  • Removed useless debug flag (does nothing, goes nowhere)

@mvicenzi mvicenzi added the bug Something isn't working label Oct 8, 2024
@mvicenzi mvicenzi requested a review from aheggest October 8, 2024 01:44
@mvicenzi mvicenzi self-assigned this Oct 8, 2024
Copy link
Contributor

@aheggest aheggest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! I tested these commits locally and the standard stage0 and stage1 fcls seem to run fine, and I see the _rwm variables propagated into the calib ntuples.

@mmrosenberg
Copy link
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v09_91_02

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@mmrosenberg mmrosenberg merged commit e99ac9b into develop Oct 8, 2024
@mmrosenberg mmrosenberg deleted the feature/mvicenzi_rwm branch October 8, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants