Skip to content

Run-time bug fixes for PR#751 #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmrosenberg merged 3 commits into from
Oct 8, 2024
Merged

Run-time bug fixes for PR#751 #758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1118d9d
add missing class dictionary definitions
mvicenzi Oct 8, 2024
7166c8b
remove useless debug flag
mvicenzi Oct 8, 2024
ff6808e
disable waveform tree for standard running
mvicenzi Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions icaruscode/IcarusObj/classes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
#include "icaruscode/IcarusObj/CRTTPCMatchingInfo.h"
#include "icaruscode/IcarusObj/OpDetWaveformMeta.h"
#include "icaruscode/IcarusObj/PMTWaveformTimeCorrection.h"
#include "icaruscode/IcarusObj/PMTBeamSignal.h"
#include "icaruscode/IcarusObj/Hit.h"
//#include "icaruscode/IcarusObj/CRTPMTMatching.h"

Expand Down
6 changes: 6 additions & 0 deletions icaruscode/IcarusObj/classes_def.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,12 @@
<class name="std::vector<icarus::timing::PMTWaveformTimeCorrection>"/>
<class name="art::Wrapper<std::vector<icarus::timing::PMTWaveformTimeCorrection> >"/>

<!-- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -->
<!-- icarus::timing::PMTBeamSignal -->
<class name="art::Wrapper<vector<icarus::timing::PMTBeamSignal> >"/>
<class name="icarus::timing::PMTBeamSignal"/>
<class name="vector<icarus::timing::PMTBeamSignal>"/>

<!-- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -->
<!-- LArSoft object associations that are missing from LArSoft -->

Expand Down
5 changes: 0 additions & 5 deletions icaruscode/PMT/OpReco/ICARUSFlashAssAna_module.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,6 @@ class opana::ICARUSFlashAssAna : public art::EDAnalyzer
Name("PEOpHitThreshold"),
Comment("Threshold in PE for an OpHit to be considered in the information calculated for a flash")};

fhicl::Atom<bool> Debug{
Name("Debug"),
Comment("Be more verbose"),
false};
};

using Parameters = art::EDAnalyzer::Table<Config>;
Expand Down Expand Up @@ -271,7 +267,6 @@ opana::ICARUSFlashAssAna::ICARUSFlashAssAna(Parameters const &config)
fFlashLabels(config().FlashLabels()),
fRWMLabel(config().RWMLabel()),
fPEOpHitThreshold(config().PEOpHitThreshold()),
fDebug(config().Debug()),
fGeom(lar::providerFrom<geo::Geometry>())
{
}
Expand Down
3 changes: 1 addition & 2 deletions icaruscode/PMT/OpReco/fcl/icarus_opana_modules.fcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ ICARUSParticleAna: {
ICARUSFlashAssAna: {
module_type: "ICARUSFlashAssAna"
TriggerLabel: "daqTrigger"
DumpWaveformsInfo: true
DumpWaveformsInfo: false
SaveRawWaveforms: false
UseSharedBaseline: true
OpDetWaveformLabels: ["daqPMT"]
Expand All @@ -112,7 +112,6 @@ ICARUSFlashAssAna: {
FlashLabels: ["opflashCryoE", "opflashCryoW"]
RWMLabel: "beamTiming:RWM"
PEOpHitThreshold: 0
Debug: false
}

ICARUSBeamStructureAna: {
Expand Down