Skip to content

Conversation

@gputnam
Copy link
Contributor

@gputnam gputnam commented Mar 21, 2025

Refactor each T0 into its own field.

Depends on: SBNSoftware/sbnobj#124

francescopoppi and others added 2 commits March 7, 2025 14:30
…enabled, It should work for both ICARUS and SBND.
Copy link
Contributor

@linyan-w linyan-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

fTrack->t0CRT = t0CRT;
fTrack->t0PFP = t0Info.t0Pandora;
fTrack->t0CRTTrack = t0Info.t0CRTTrack;
fTrack->t0CRTHit = t0Info.t0CRTHit;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really have t0 from CRTHit? I thought we require CRT track to match TPC track to assign a CRT T0.

@kjplows kjplows moved this from Open pull requests to Testing in SBN software development Apr 7, 2025
@kjplows
Copy link
Contributor

kjplows commented Apr 7, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_07

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@kjplows
Copy link
Contributor

kjplows commented Apr 7, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_07 SBNSoftware/sbnobj#124

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Testing to To merge in SBN software development Apr 7, 2025
@kjplows kjplows merged commit 4564c9e into develop Apr 11, 2025
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development Apr 11, 2025
@kjplows kjplows moved this from Done to To merge in SBN software development Apr 11, 2025
@kjplows kjplows moved this from To merge to Recently done in SBN software development Apr 11, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Addresses one or more bugs

Projects

Status: Done
Status: Todo

Development

Successfully merging this pull request may close these issues.

The CRT Track Updates Break Portability of the Calibration NTupler

8 participants