Refactor each T0 in Calibration NTupler into its own field #124

gputnam · 2025-03-21T19:40:05Z

No description provided.

…HitTagging information. Modification of the TrackCaloSkimmerObj to include CRT tagged tracks.

francescopoppi

I do approve this PR, thanks @gputnam for merging in my SBNObj data products

francescopoppi · 2025-03-27T13:41:07Z

May I suggest adding @henrylay97 as an additional reviewer?

henrylay97

I have a few comments. They mainly stem from the SBND-side of things. In general this looks good to me, ICARUS folks should obviously comment on the integration of this into your workflow, my comments are limited to what features help us make use of this in future! :D

sbnobj/Common/CRT/CRTHitT0TaggingInfo.hh

sbnobj/Common/Calibration/TrackCaloSkimmerObj.h

henrylay97

All looks great other than one picky final comment

sbnobj/Common/Calibration/TrackCaloSkimmerObj.h

kjplows · 2025-04-10T11:03:05Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_07

FNALbuild · 2025-04-10T11:16:24Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2025-04-10T11:19:30Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2025-04-10T11:28:31Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-04-10T11:28:43Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-04-10T11:28:53Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-04-10T11:32:10Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

kjplows · 2025-04-10T11:44:07Z

@francescopoppi there are build failures on e26:prof, can you take a look please?

/scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/Calibration/TrackCaloSkimmer_module.cc
4341: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/Calibration/TrackCaloSkimmer_module.cc: In member function 'virtual void sbn::TrackCaloSkimmer::analyze(const art::Event&)':
4342: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/Calibration/TrackCaloSkimmer_module.cc:404:28: error: 'struct sbn::TrackInfo' has no member named 't0CRT'
4343:   404 |         if (!isnan(fTrack->t0CRT) && isnan(fTrack->t0))
4344:       |                            ^~~~~
4345: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/Calibration/TrackCaloSkimmer_module.cc:404:52: error: 'struct sbn::TrackInfo' has no member named 't0'
4346:   404 |         if (!isnan(fTrack->t0CRT) && isnan(fTrack->t0))
4347:       |                                                    ^~
4348: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/Calibration/TrackCaloSkimmer_module.cc:406:28: error: 'struct sbn::TrackInfo' has no member named 't0CRT'
4349:   406 |         if (!isnan(fTrack->t0CRT) && !isnan(fTrack->t0))
4350:       |                            ^~~~~
4351: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/Calibration/TrackCaloSkimmer_module.cc:406:53: error: 'struct sbn::TrackInfo' has no member named 't0'
4352:   406 |         if (!isnan(fTrack->t0CRT) && !isnan(fTrack->t0))
4353:       |                                                     ^~
4354: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/Calibration/TrackCaloSkimmer_module.cc: In member function 'void sbn::TrackCaloSkimmer::FillTrack(const recob::Track&, const recob::PFParticle&, float, float, const std::vector<art::Ptr<recob::Hit> >&, const std::vector<const recob::TrackHitMeta*>&, const std::vector<art::Ptr<recob::SpacePoint> >&, const std::vector<art::Ptr<anab::Calorimetry> >&, const std::map<geo::WireID, art::Ptr<raw::RawDigit> >&, const std::vector<GlobalTrackInfo>&, const geo::WireReadoutGeom*, const detinfo::DetectorClocksData&, const cheat::BackTrackerService*, sbn::EDet, const detinfo::DetectorPropertiesData&)':
4355: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/Calibration/TrackCaloSkimmer_module.cc:1081:11: error: 'struct sbn::TrackInfo' has no member named 't0'
4356:  1081 |   fTrack->t0 = t0;
4357:       |           ^~
4358: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/Calibration/TrackCaloSkimmer_module.cc:1082:11: error: 'struct sbn::TrackInfo' has no member named 't0CRT'
4359:  1082 |   fTrack->t0CRT = t0CRT;
4360:       |           ^~~~~
4361: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/Calibration/TrackCaloSkimmer_module.cc:1096:22: error: 'struct sbn::TrackInfo' has no member named 't0'
4362:  1096 |   if (!isnan(fTrack->t0)) {
4363:       |                      ^~
4364: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/Calibration/TrackCaloSkimmer_module.cc:1100:26: error: 'struct sbn::TrackInfo' has no member named 't0'
4365:  1100 |   else if (isnan(fTrack->t0) && !isnan(fTrack->t0CRT)) {
4366:       |                          ^~
4367: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbncode/sbncode/Calibration/TrackCaloSkimmer_module.cc:1100:48: error: 'struct sbn::TrackInfo' has no member named 't0CRT'
4368:  1100 |   else if (isnan(fTrack->t0) && !isnan(fTrack->t0CRT)) {
4369:

kjplows · 2025-04-10T19:48:09Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_07 SBNSoftware/sbncode#525

FNALbuild · 2025-04-10T20:01:23Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2025-04-10T20:04:30Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2025-04-10T20:09:31Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-04-10T20:10:28Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-04-10T20:22:52Z

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-04-10T20:25:54Z

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

kjplows · 2025-04-11T15:01:20Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_07 SBNSoftware/sbncode#525

FNALbuild · 2025-04-11T15:13:00Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2025-04-11T15:14:40Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2025-04-11T15:22:01Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-04-11T15:22:20Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-04-11T15:22:24Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2025-04-11T15:22:55Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

kjplows · 2025-04-11T15:45:43Z

merging as this builds OK on build machines with LArSoft 10_04_08 (release target) and CI failures are due to reference files not being updated (after chat with @bear-is-asleep who checked the errors, many thanks!)

francescopoppi and others added 2 commits March 7, 2025 14:28

This commit does the following: creation of data product with the CRT…

4cd4934

…HitTagging information. Modification of the TrackCaloSkimmerObj to include CRT tagged tracks.

Split out t0s into separate variables.

1499884

This was referenced Mar 21, 2025

Fix Handling of CRT in Calbiration NTupler SBNSoftware/sbncode#525

Merged

Updates to Enable ICARUS Spring Production SBNSoftware/sbncode#526

Merged

kjplows added this to SBN software development Mar 26, 2025

kjplows moved this to Open pull requests in SBN software development Mar 26, 2025

Merge branch 'develop' into feature/gp-calibntupler-v10

316a0ff

francescopoppi approved these changes Mar 27, 2025

View reviewed changes

francescopoppi requested a review from henrylay97 March 27, 2025 13:41

francescopoppi mentioned this pull request Mar 27, 2025

CRTT0Tagging - icaruscode v10 SBNSoftware/icaruscode#814

Merged

kjplows moved this from Open pull requests to Partially reviewed in SBN software development Mar 27, 2025

henrylay97 reviewed Mar 31, 2025

View reviewed changes

francescopoppi added 2 commits April 10, 2025 10:40

Address comments and requests from Henry

a543c37

Fixed order in the initialization

7d32e4d

henrylay97 requested changes Apr 10, 2025

View reviewed changes

sbnobj/Common/Calibration/TrackCaloSkimmerObj.h Outdated Show resolved Hide resolved

Addressed a final request from Henry

e9aa1f1

henrylay97 self-requested a review April 10, 2025 09:27

henrylay97 approved these changes Apr 10, 2025

View reviewed changes

kjplows moved this from Partially reviewed to Testing in SBN software development Apr 10, 2025

Merge branch 'develop' into feature/gp-calibntupler-v10

923a8d9

kjplows moved this from Testing to To merge in SBN software development Apr 11, 2025

kjplows merged commit 55654b2 into develop Apr 11, 2025
2 of 6 checks passed

github-project-automation bot moved this from To merge to Done in SBN software development Apr 11, 2025

kjplows moved this from Done to Recently done in SBN software development Apr 11, 2025

This was referenced Apr 17, 2025

Feature/aantonak crtveto #127

Merged

Introduction of CRTT0TaggingInfo #117

Closed

kjplows moved this from Recently done to Done in SBN software development Apr 18, 2025

mvicenzi moved this from Done to Testing in SBN software development Jul 9, 2025

mvicenzi moved this from Testing to Done in SBN software development Jul 9, 2025

Refactor each T0 in Calibration NTupler into its own field #124

Refactor each T0 in Calibration NTupler into its own field #124

Uh oh!

Conversation

gputnam commented Mar 21, 2025

Uh oh!

francescopoppi left a comment

Choose a reason for hiding this comment

Uh oh!

francescopoppi commented Mar 27, 2025

Uh oh!

henrylay97 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

henrylay97 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kjplows commented Apr 10, 2025

Uh oh!

FNALbuild commented Apr 10, 2025

Uh oh!

FNALbuild commented Apr 10, 2025

Uh oh!

FNALbuild commented Apr 10, 2025

Uh oh!

FNALbuild commented Apr 10, 2025

Uh oh!

FNALbuild commented Apr 10, 2025

Uh oh!

FNALbuild commented Apr 10, 2025

Uh oh!

kjplows commented Apr 10, 2025

Uh oh!

kjplows commented Apr 10, 2025

Uh oh!

FNALbuild commented Apr 10, 2025

Uh oh!

FNALbuild commented Apr 10, 2025

Uh oh!

FNALbuild commented Apr 10, 2025

Uh oh!

FNALbuild commented Apr 10, 2025

Uh oh!

FNALbuild commented Apr 10, 2025

Uh oh!

FNALbuild commented Apr 10, 2025

Uh oh!

kjplows commented Apr 11, 2025

Uh oh!

FNALbuild commented Apr 11, 2025

Uh oh!

FNALbuild commented Apr 11, 2025

Uh oh!

FNALbuild commented Apr 11, 2025

Uh oh!

FNALbuild commented Apr 11, 2025

Uh oh!

FNALbuild commented Apr 11, 2025

Uh oh!

FNALbuild commented Apr 11, 2025

Uh oh!

kjplows commented Apr 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants