Skip to content

Feature/acastill pmtdatabaseinterface #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nathanielerowe merged 23 commits into from
Apr 25, 2025
Merged

Feature/acastill pmtdatabaseinterface #673

nathanielerowe merged 23 commits into from
Apr 25, 2025

Conversation

@asanchezcastillo
Copy link
Contributor

@asanchezcastillo asanchezcastillo commented Mar 5, 2025 •
edited
Loading

Description

This pull request introduces the required service to access the pds calibration database from any LArSoft module. It does also modifies services_sbnd.fcl to include the service by default. This PR requires to have an updated version of sbnd_data to include the .db file containing the information to read. This can be found in /exp/sbnd/app/users/acastill/Database/sbnd_data.

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

@asanchezcastillo asanchezcastillo added the enhancement New feature or request label Mar 5, 2025
@asanchezcastillo asanchezcastillo self-assigned this Mar 5, 2025
@lynnt20
Copy link
Contributor

lynnt20 commented Mar 5, 2025

about to pull down (with your new updates) and test again. One note; might be good to add a README.md in /exp/sbnd/app/users/acastill/Database/sbnd_data/v01_27_00/CalibrationDatabase/ with an entry describing the addition of the `.db' file (relevant dates, details, etc.)

lynnt20
lynnt20 approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@lynnt20 lynnt20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed everything ran well, thanks!!

@asanchezcastillo asanchezcastillo mentioned this pull request Mar 14, 2025
Merged
6 tasks
@bear-is-asleep
Copy link
Contributor

bear-is-asleep commented Mar 27, 2025

@asanchezcastillo can you check the failures? It seems that pds_calibration.db can't be found. But I see it in /cvmfs/sbnd.opensciencegrid.org/products/sbnd/sbnd_data/v01_29_00/CalibrationDatabase/pds_calibration.db.

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 8, 2025

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 8, 2025

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@bear-is-asleep bear-is-asleep moved this to To be Merged (RM only) in SBND March 2025 production Apr 8, 2025
@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 8, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 8, 2025

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@bear-is-asleep
Copy link
Contributor

bear-is-asleep commented Apr 10, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_06 SBNSoftware/sbncode@v10_04_06_p01 SBNSoftware/sbnanaobj@bug/coackley_caf_Mar25 SBNSoftware/sbnobj@v10_00_07

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 10, 2025

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 10, 2025

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 10, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 10, 2025

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@bear-is-asleep
Copy link
Contributor

bear-is-asleep commented Apr 16, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_07 SBNSoftware/sbncode@v10_04_07 SBNSoftware/sbnalg@v10_04_07 SBNSoftware/sbnobj@v10_00_08

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 16, 2025

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 16, 2025

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 16, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 16, 2025

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@bear-is-asleep
Copy link
Contributor

bear-is-asleep commented Apr 16, 2025

Approved

@nathanielerowe
Copy link
Contributor

nathanielerowe commented Apr 24, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_08 SBNSoftware/sbncode@v10_04_08 SBNSoftware/sbnalg@v10_04_08 SBNSoftware/sbnobj@v10_00_08

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 24, 2025

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 24, 2025

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 24, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 24, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe
Copy link
Contributor

nathanielerowe commented Apr 25, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_05_00 SBNSoftware/sbncode#533

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 25, 2025

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 25, 2025

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 25, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 25, 2025

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe nathanielerowe merged commit e2d0ede into develop Apr 25, 2025
3 of 4 checks passed
@asanchezcastillo asanchezcastillo deleted the feature/acastill_pmtdatabaseinterface branch June 18, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@linyan-w linyan-w linyan-w approved these changes

@lynnt20 lynnt20 lynnt20 approved these changes

@VCLanNguyen VCLanNguyen Awaiting requested review from VCLanNguyen

Assignees

@asanchezcastillo asanchezcastillo

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@asanchezcastillo @lynnt20 @bear-is-asleep @FNALbuild @nathanielerowe @linyan-w