Skip to content

Feature/acastill deconvolution database #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nathanielerowe merged 8 commits into from
Jun 27, 2025
Merged

Feature/acastill deconvolution database #683

nathanielerowe merged 8 commits into from
Jun 27, 2025

Conversation

@asanchezcastillo
Copy link
Contributor

@asanchezcastillo asanchezcastillo commented Mar 14, 2025 •
edited by bear-is-asleep
Loading

Description

This pull request modifies the optical deconvolution module to retrieve the values for the single electron response, SPE and noise filter parameters from the calibration database. This PR is to be merged with #673 .

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?

Relevant PR links (optional)

#673

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

@asanchezcastillo asanchezcastillo added the reco1/reco2 Reconstruction label Mar 14, 2025
@asanchezcastillo asanchezcastillo self-assigned this Mar 14, 2025
@bear-is-asleep
Copy link
Contributor

bear-is-asleep commented Mar 26, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_06 SBNSoftware/sbncode@v10_04_06_01

@FNALbuild
Copy link
Collaborator

FNALbuild commented Mar 27, 2025

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Mar 27, 2025

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Mar 27, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Mar 27, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@bear-is-asleep
Copy link
Contributor

bear-is-asleep commented Mar 27, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_06 SBNSoftware/sbncode@v10_04_06_p01

@FNALbuild
Copy link
Collaborator

FNALbuild commented Mar 27, 2025

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Mar 27, 2025

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Mar 27, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Mar 27, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@bear-is-asleep
Copy link
Contributor

bear-is-asleep commented Apr 2, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_06 SBNSoftware/sbncode@v10_04_06_p01 SBNSoftware/sbnanaobj@bug/coackley_caf_Mar25 SBNSoftware/sbnobj@v10_00_07

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 2, 2025

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 2, 2025

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 2, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 2, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@bear-is-asleep
Copy link
Contributor

bear-is-asleep commented Apr 3, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_06 SBNSoftware/sbncode@v10_04_06_p01 SBNSoftware/sbnanaobj@bug/coackley_caf_Mar25 SBNSoftware/sbnobj@v10_00_07

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 3, 2025

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 3, 2025

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 3, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 3, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@bear-is-asleep bear-is-asleep marked this pull request as draft April 8, 2025 16:15
@nathanielerowe nathanielerowe marked this pull request as ready for review May 27, 2025 19:35
@nathanielerowe
Copy link
Contributor

nathanielerowe commented May 28, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_06_00

@FNALbuild
Copy link
Collaborator

FNALbuild commented May 28, 2025

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented May 28, 2025

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented May 28, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented May 28, 2025

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe
Copy link
Contributor

nathanielerowe commented May 28, 2025

Approved

@nathanielerowe
Copy link
Contributor

nathanielerowe commented Jun 27, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_06_00

@FNALbuild
Copy link
Collaborator

FNALbuild commented Jun 27, 2025

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Jun 27, 2025

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Jun 27, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Jun 27, 2025

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe
Copy link
Contributor

nathanielerowe commented Jun 27, 2025

Some minuscule cnn output changes and data product sizes. Still approved.

@nathanielerowe nathanielerowe merged commit 945728f into develop Jun 27, 2025
@asanchezcastillo asanchezcastillo deleted the feature/acastill_deconvolution_database branch July 14, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@linyan-w linyan-w linyan-w approved these changes

@fjnicolas fjnicolas fjnicolas approved these changes

Assignees

@asanchezcastillo asanchezcastillo

Labels

reco1/reco2 Reconstruction

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@asanchezcastillo @bear-is-asleep @FNALbuild @nathanielerowe @linyan-w @fjnicolas