Skip to content

Conversation

@marcodeltutto
Copy link
Member

@marcodeltutto marcodeltutto commented Mar 20, 2025

Update GeomScan file with current GDML/Flux.

Also, adds a cmake test to ensure that the GeomScan file is compatible with the current flux and gdml versions.
This test requires fhiclpy, which has been added as a ups dependency.

Needs /exp/sbnd/app/users/mdeltutt/sbnd_data to be tagged as new version of sbnd_data (added sbnd_data/GENIE/sbnd_rock_maxpathlength_fluxL_gdmlv02_03.xml).

Fixes #654, fixes #519.

Description

Please provide a detailed description of the changes this pull request introduces.

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer. No
  • Does this affect the standard workflow? Yes

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

@marcodeltutto marcodeltutto mentioned this pull request Mar 24, 2025
6 tasks
Copy link
Contributor

@bear-is-asleep bear-is-asleep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I can make sure the sbn dependencies are fine

@bear-is-asleep
Copy link
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_06 SBNSoftware/sbncode@v10_04_06_01

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored failure for unit_test -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@marcodeltutto
Copy link
Member Author

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_06 SBNSoftware/sbncode@v10_04_06_01

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@marcodeltutto
Copy link
Member Author

My last commit fixed the unit test failure.
CI output is expected.

@bear-is-asleep
Copy link
Contributor

Approved

@bear-is-asleep bear-is-asleep moved this from Todo to To be Merged (RM only) in SBND March 2025 production Mar 27, 2025
@bear-is-asleep bear-is-asleep moved this from To be Merged (RM only) to Approved (RM only) in SBND March 2025 production Mar 27, 2025
@bear-is-asleep bear-is-asleep merged commit 9406ca5 into develop Apr 1, 2025
3 of 4 checks passed
@bear-is-asleep bear-is-asleep moved this from Approved (RM only) to In tagged release in SBND March 2025 production Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In tagged release

Development

Successfully merging this pull request may close these issues.

Update GeomScan File to Latest GDML Version Update sbnd_data

4 participants