Skip to content

Updating calibration constants with values measured using 2025A Spring Dev Samples #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nathanielerowe merged 1 commit into from
Apr 25, 2025
Merged

Updating calibration constants with values measured using 2025A Spring Dev Samples #719

nathanielerowe merged 1 commit into from
Apr 25, 2025

Conversation

@sungbinoh
Copy link
Contributor

@sungbinoh sungbinoh commented Apr 11, 2025 •
edited
Loading

Description

Updating TPC gain calibration constants for MC and Data with values measured using 2025A Spring Dev Samples.

Bellow figure is based on Moon's proton selection shown in page 7 of SBN-doc-40729.
Updated calibration constant provides better agreement between MC and Data in chi2 distribution.
The figure is using only collection plane. This PR updates calibration constants for all three planes.

Screenshot 2025-04-10 at 10 38 35 PM

This PR affects both Reco2 and CAF, for all processes that use TPC gain calibration constants.

Checklist

  • [ V] Added at least 1 label from available labels.
  • [ V] Assigned at least 1 reviewer under Reviewers,
  • [ V] Assigned all contributers including yourself under Assignees
  • [ V] Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • [ V] Does this affect the standard workflow?

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
No

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?
SBN-doc-40714

@sungbinoh sungbinoh added reco1/reco2 Reconstruction caf Common analysis framework labels Apr 11, 2025
@sungbinoh sungbinoh requested review from linyan-w and mrmooney April 11, 2025 03:49
@sungbinoh sungbinoh self-assigned this Apr 11, 2025
@sungbinoh sungbinoh linked an issue Apr 11, 2025 that may be closed by this pull request
Updating TPC gain calibration constants #718
Closed
2 tasks
linyan-w
linyan-w approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@linyan-w linyan-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sungbinoh , this fcl works as a temporary solution for the spring production. Since this value is iterating, I think it makes sense to put it into the calibration database instead of a fcl file from now on, though it should not change with time once we figure out the cause.

@sungbinoh sungbinoh requested a review from mrguzzo April 11, 2025 14:31
@sungbinoh
Copy link
Contributor Author

sungbinoh commented Apr 11, 2025

Hi @sungbinoh , this fcl works as a temporary solution for the spring production. Since this value is iterating, I think it makes sense to put it into the calibration database instead of a fcl file from now on, though it should not change with time once we figure out the cause.

Hi @linyan-w , thank you for the comment! Adding @mrguzzo to reviewers.
Hi @mrguzzo, could you please populate the SBND calibration DB the updated calibration constants?

MC 2025A spring
plane0	plane1	plane2
0.02052, 0.02044, 0.02019

Data 20225A spring
plane0	plane1	plane2
0.02172, 0.02150, 0.02103

where

plane0: the first induction plane
plane1: the second induction plane
plane2: the collection plane

@bear-is-asleep
Copy link
Contributor

bear-is-asleep commented Apr 16, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_07 SBNSoftware/sbncode@v10_04_07 SBNSoftware/sbnalg@v10_04_07 SBNSoftware/sbnobj@v10_00_08

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 16, 2025

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 16, 2025

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 16, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 16, 2025

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@bear-is-asleep
Copy link
Contributor

bear-is-asleep commented Apr 16, 2025

Approved

@bear-is-asleep bear-is-asleep moved this from Todo to Approved (RM only) in SBND March 2025 production Apr 17, 2025
@nathanielerowe
Copy link
Contributor

nathanielerowe commented Apr 24, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_08 SBNSoftware/sbncode@v10_04_08 SBNSoftware/sbnalg@v10_04_08 SBNSoftware/sbnobj@v10_00_08

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 24, 2025

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 24, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 24, 2025

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 24, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe
Copy link
Contributor

nathanielerowe commented Apr 25, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_05_00 SBNSoftware/sbncode#533

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 25, 2025

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 25, 2025

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 25, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Apr 25, 2025

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe nathanielerowe merged commit 10a2cf2 into develop Apr 25, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrmooney mrmooney mrmooney approved these changes

@linyan-w linyan-w linyan-w approved these changes

@mrguzzo mrguzzo Awaiting requested review from mrguzzo

Assignees

@sungbinoh sungbinoh

@wjdanswjddl wjdanswjddl

Labels

caf Common analysis framework reco1/reco2 Reconstruction

Projects

SBND March 2025 production
Status: Approved (RM only)

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Updating TPC gain calibration constants

8 participants

@sungbinoh @bear-is-asleep @FNALbuild @nathanielerowe @mrmooney @linyan-w @wjdanswjddl